424 onionize the sitekit configuration checks

[thijsoo]

Context

• We want to make sure there is one way to detect if the configuration is finished

Summary

This PR can be summarized in the following changelog entry:

• Changes the way we detect if the plugin is configured.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

• Use the test instructions from 364 add the integration card for google site kit #21946

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

• This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes #

[vraja-pro]

We should change the names of the boolean values and the class to either include the full name or a short version like GSK

[vraja-pro]

CR & AC ✅

[coveralls]

Pull Request Test Coverage Report for Build 37cd0064c338531cd951fc5cf9d68463ae58a3c4

Details

• 7 of 35 (20.0%) changed or added relevant lines in 3 files are covered.
• 1012 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-0.03%) to 54.507%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/js/src/integrations-page/recommended-integrations.js	0	4	0.0%
src/dashboard/infrastructure/integrations/site-kit.php	0	24	0.0%

Files with Coverage Reduction	New Missed Lines	%
packages/js/src/integrations-page/recommended-integrations.js	1	0.0%
src/generated/container.php	1011	0.38%

Totals
Change from base Build fedc1b286bb15dc44c2150ae129cd3beba01321d:	-0.03%
Covered Lines:	30169
Relevant Lines:	55784

---

💛 - Coveralls