Fix webhooks: they should return response.empty (no error) on github_…

…post if it's not a valid PR
YunoHost · Aug 17, 2024 · 6c431bb · 6c431bb
1 parent 4ca6d03
commit 6c431bb
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/tools/webhooks/requirements.txt b/tools/webhooks/requirements.txt
@@ -0,0 +1,9 @@
+jinja2
+sanic==21.12.2
+GitPython
+pyyaml
+toml
+websockets==10.0
+babel
+langcodes
+language_data
diff --git a/tools/webhooks/webhook.py b/tools/webhooks/webhook.py
@@ -73,6 +73,8 @@ async def github_post(request: Request) -> HTTPResponse:
 
         if valid_pr_comment:
             return on_pr_comment(request, pr_infos)
+        else:
+            return response.empty()
 
     return response.json({"error": f"Unknown event '{event}'"}, 422)