Use samesite lax for portal cookies #2018
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
YunoHost-Apps/synapse_ynh#497
After more investigation it seem to be related to the
samesite
settings of theyunohost.portal
cookie.So I did 2 test one with yunohost 11 and one with yunohost 12. With this process:
Now try to do this small fix on yunohost 12 and see that it solve the issue.
Note that there was already a discussion about this some year ago here: YunoHost/SSOwat#103
Solution
Use the same settings than on bullseye for the SSO cookie.
PR Status
Tested and it fixed the issue
How to test
Try to connect to a synapse server on a yunohost instance from https://app.element.io