add panel border for ggmark and cross_mark

Yunuuuu · Jan 9, 2025 · b68bb95 · b68bb95
1 parent d0274bf
commit b68bb95
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/R/cross-mark.R b/R/cross-mark.R
@@ -37,7 +37,7 @@ cross_mark <- function(mark, data = waiver(), reorder = NULL, obs_size = 1,
     cross(CrossMark,
         data = data, mark = mark, reorder = reorder, obs_size = obs_size,
         plot = ggplot(), size = size,
-        schemes = default_schemes(),
+        schemes = default_schemes(th = theme_panel_border()),
         active = active,
         inherit_nobs = inherit_nobs,
         inherit_panel = inherit_panel,

diff --git a/R/ggmark.R b/R/ggmark.R
@@ -81,7 +81,7 @@ ggmark <- function(mark, data = waiver(), mapping = aes(), ...,
         # slot
         plot = ggplot(mapping = mapping),
         size = size,
-        schemes = default_schemes(data),
+        schemes = default_schemes(data, th = theme_panel_border()),
         active = active
     )
 }

diff --git a/R/ggplot-theme.R b/R/ggplot-theme.R
@@ -28,6 +28,8 @@ theme_no_strip <- function() {
     )
 }
 
+theme_panel_border <- function() theme(panel.border = element_rect(fill = NA))
+
 #' @importFrom utils packageVersion
 #' @importFrom rlang try_fetch
 complete_theme <- function(theme) {