Merge pull request #323 from YusukeIwaki/driver/1.50.0

Update playwright driver to 1.50.1
YusukeIwaki · Feb 2, 2025 · 81f82b1 · 81f82b1
2 parents 7a3f758 + 4f1b708
commit 81f82b1
Show file tree

Hide file tree

Showing 26 changed files with 1,290 additions and 234 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -4,8 +4,8 @@ jobs:
   test-remote:
     docker:
       - image: cimg/ruby:3.3.0
-      - image: mcr.microsoft.com/playwright:v1.45.0-jammy
-        command: /bin/sh -c "cd /home/pwuser ; npx --yes playwright@1.45.0 install && npx playwright@1.45.0 run-server --port 8888 --host 0.0.0.0 --path /ws"
+      - image: mcr.microsoft.com/playwright:v1.50.1-noble
+        command: /bin/sh -c "cd /home/pwuser ; npx --yes playwright@1.50.1 install && npx playwright@1.50.1 run-server --port 8888 --host 0.0.0.0 --path /ws"
         environment:
           DEBUG: "pw:*"
         user: pwuser

diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml
@@ -10,7 +10,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 3.1
+          ruby-version: 3.4
           bundler-cache: true
       - name: Download playwright driver
         run: |

diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -16,7 +16,7 @@ jobs:
     - uses: actions/checkout@v3
     - uses: ruby/setup-ruby@v1
       with:
-        ruby-version: 3.1
+        ruby-version: 3.4
         bundler-cache: true
     - name: Check Playwright::version
       run: bundle exec ruby -e 'raise "invalid Playwright::VERSION" unless Playwright::VERSION == ENV["RELEASE_TAG"]'

diff --git a/.github/workflows/rspec.yml b/.github/workflows/rspec.yml
@@ -5,103 +5,104 @@ on:
     paths-ignore:
       - development/generate_api/example_codes.rb
       - development/unimplemented_examples.md
-      - 'documentation/**'
+      - "documentation/**"
       - spec/integration/example_spec.rb
 
 jobs:
   unit_test:
     name: Unit test
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
-    - uses: ruby/setup-ruby@v1
-      with:
-        ruby-version: 3.2
-        bundler-cache: true
-    - run: |
-        rm -rf spec/integration
-        bundle exec rspec
+      - uses: actions/checkout@v3
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.4
+          bundler-cache: true
+      - run: |
+          rm -rf spec/integration
+          bundle exec rspec
 
   generate_playwright_api:
     name: Generate Playwright API codes
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
-    - uses: ruby/setup-ruby@v1
-      with:
-        ruby-version: 3.2
-        bundler-cache: true
-    - run: bundle exec ruby development/generate_api.rb
-    - uses: actions/upload-artifact@v3
-      with:
-        name: playwright_api
-        path: lib/playwright_api
+      - uses: actions/checkout@v3
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.4
+          bundler-cache: true
+      - run: bundle exec ruby development/generate_api.rb
+      - uses: actions/upload-artifact@v4
+        with:
+          name: playwright_api
+          path: lib/playwright_api
 
   integration_test_with_npm_playwright_driver:
     needs: [unit_test, generate_playwright_api]
     strategy:
       fail-fast: false
       matrix:
-        ruby_version: [2.7, 3.0, 3.1, 3.2]
+        ruby_version: [2.7, 3.1, 3.2, 3.3, 3.4]
         browser: [chromium, webkit]
     name: (${{ matrix.browser }}/Ruby${{ matrix.ruby_version }}) Integration test
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
-    - uses: ruby/setup-ruby@v1
-      with:
-        ruby-version: ${{ matrix.ruby_version }}
-        bundler-cache: true
-    - uses: actions/setup-node@v3
-      with:
-        node-version: 16
-    - name: setup ${{ matrix.version }} playwright via npm install
-      run: |
-        export PLAYWRIGHT_CLI_VERSION=$(bundle exec ruby -e 'puts Playwright::COMPATIBLE_PLAYWRIGHT_VERSION.strip')
-        npm install playwright@${PLAYWRIGHT_CLI_VERSION} || npm install playwright@next
-        ./node_modules/.bin/playwright install ${{ matrix.browser }}
-        ./node_modules/.bin/playwright install-deps
-    - name: Download playwright_api codes
-      uses: actions/download-artifact@v3
-      with:
-        name: playwright_api
-        path: lib/playwright_api
-    - run: bundle exec rspec spec/integration --profile 10
-      env:
-        BROWSER: ${{ matrix.browser }}
-        PLAYWRIGHT_CLI_EXECUTABLE_PATH: ./node_modules/.bin/playwright
-      timeout-minutes: 25
+      - uses: actions/checkout@v3
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby_version }}
+          bundler-cache: true
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 22
+      - name: setup ${{ matrix.version }} playwright via npm install
+        run: |
+          export PLAYWRIGHT_CLI_VERSION=$(bundle exec ruby -e 'puts Playwright::COMPATIBLE_PLAYWRIGHT_VERSION.strip')
+          npm install playwright@${PLAYWRIGHT_CLI_VERSION} || npm install playwright@next
+          ./node_modules/.bin/playwright install ${{ matrix.browser }}
+          ./node_modules/.bin/playwright install-deps
+          sudo apt-get install -y ffmpeg
+      - name: Download playwright_api codes
+        uses: actions/download-artifact@v4
+        with:
+          name: playwright_api
+          path: lib/playwright_api
+      - run: bundle exec rspec spec/integration --profile 10
+        env:
+          BROWSER: ${{ matrix.browser }}
+          PLAYWRIGHT_CLI_EXECUTABLE_PATH: ./node_modules/.bin/playwright
+        timeout-minutes: 25
 
   integration_test_with_npm_playwright_driver_and_old_ruby:
     needs: [unit_test, generate_playwright_api]
     strategy:
       fail-fast: false
       matrix:
-        ruby_version: [2.4, 2.5, 2.6]
+        ruby_version: [2.4, 2.5, 2.6, 3.0]
     name: (chromium/Ruby${{ matrix.ruby_version }}) example_spec
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
-    - uses: ruby/setup-ruby@v1
-      with:
-        ruby-version: ${{ matrix.ruby_version }}
-        bundler-cache: true
-    - uses: actions/setup-node@v3
-      with:
-        node-version: 16
-    - name: setup ${{ matrix.version }} playwright via npm install
-      run: |
-        export PLAYWRIGHT_CLI_VERSION=$(bundle exec ruby -e 'puts Playwright::COMPATIBLE_PLAYWRIGHT_VERSION.strip')
-        npm install playwright@${PLAYWRIGHT_CLI_VERSION} || npm install playwright@next
-        ./node_modules/.bin/playwright install chromium
-        ./node_modules/.bin/playwright install-deps
-    - name: Download playwright_api codes
-      uses: actions/download-artifact@v3
-      with:
-        name: playwright_api
-        path: lib/playwright_api
-    - run: bundle exec rspec spec/integration/example_spec.rb
-      env:
-        BROWSER: chromium
-        PLAYWRIGHT_CLI_EXECUTABLE_PATH: ./node_modules/.bin/playwright
-      timeout-minutes: 10
+      - uses: actions/checkout@v3
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby_version }}
+          bundler-cache: true
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 22
+      - name: setup ${{ matrix.version }} playwright via npm install
+        run: |
+          export PLAYWRIGHT_CLI_VERSION=$(bundle exec ruby -e 'puts Playwright::COMPATIBLE_PLAYWRIGHT_VERSION.strip')
+          npm install playwright@${PLAYWRIGHT_CLI_VERSION} || npm install playwright@next
+          ./node_modules/.bin/playwright install chromium
+          ./node_modules/.bin/playwright install-deps
+      - name: Download playwright_api codes
+        uses: actions/download-artifact@v4
+        with:
+          name: playwright_api
+          path: lib/playwright_api
+      - run: bundle exec rspec spec/integration/example_spec.rb
+        env:
+          BROWSER: chromium
+          PLAYWRIGHT_CLI_EXECUTABLE_PATH: ./node_modules/.bin/playwright
+        timeout-minutes: 10
diff --git a/.github/workflows/windows_check.yml b/.github/workflows/windows_check.yml
@@ -9,11 +9,11 @@ jobs:
         uses: actions/checkout@v3
       - uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 3.1
+          ruby-version: 3.4
           bundler-cache: true
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 22
       - name: Install playwright driver via npx
         run: |
           npx playwright@next install chromium

diff --git a/development/CLI_VERSION b/development/CLI_VERSION
@@ -1 +1 @@
-1.49.0
+1.50.1