all: best-effort at zeroization of secrets #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradoplg
force-pushed
the
update-deps
branch
from
a32d1a7 to
1c227b6
Compare
conradoplg
force-pushed
the
improve-zeroization
branch
from
ebb3c8a to
58b9e6d
Compare
conradoplg
force-pushed
the
improve-zeroization
branch
from
58b9e6d to
194db8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Possibly?) Closes #471
Depends on #469
I don't think this fully addresses the issue. I believe to have a good level of assurance of secrets being deleted we might need to improve frost_core zeroization handling. I created ZcashFoundation/frost#877 to track it.