-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(release): Update release script and check it in CI #7128
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7128 +/- ##
==========================================
+ Coverage 77.33% 77.41% +0.08%
==========================================
Files 310 310
Lines 41828 41828
==========================================
+ Hits 32347 32383 +36
+ Misses 9481 9445 -36 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you for getting started on automating some release steps!
I'm not sure about the workaround for cargo publish, I think it would have to be applied to every crate that depends on another crate in the workspace. It may be better to wait until there's more support for this use case, or to try an ephemeral private registry (ktra should mirror crates.io for Zebra's external deps).
This is actually a specific bug that's triggered by Zebra's dependency tree: Normally, |
bc10af7
to
3e39e5d
Compare
Ok, the new job works in CI:
https://github.com/ZcashFoundation/zebra/actions/runs/5450302581/jobs/9915420110?pr=7128#step:7:235 |
I just added this check to the branch protection rules |
Motivation
The script in our release checklist doesn't actually work.
Specifications
cargo release
command reference:https://github.com/crate-ci/cargo-release/blob/master/docs/reference.md
Complex Code or Requirements
This PR works around a
cargo publish
unpublished version resolution bug, by skipping the failing Zebra crates:crate-ci/cargo-release#691
This bug only happens in dry runs, publishing crates works fine.
Solution
Release Checklist Fixes:
do-not-merge
tags at the right timesRelease Config Fixes:
CI:
Release v1.0.1 Cleanups
Admin Actions
Review
This is a routine fix.
Reviewer Checklist
Follow Up Work
We could move the script into a file
We could automate releases and do them from GitHub Actions