fix(state): Avoid panics and history tree consensus database concurrency bugs #7590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scheduling
This PR should probably get in before the 1.3.0 release, because it fixes a panic bug.
Motivation
Close #7581
Zebra Designs
These are the only column families that:
https://github.com/ZcashFoundation/zebra/blob/main/book/src/dev/state-db-upgrades.md#current-state-database-format
(The UTXOs get deleted, but missing UTXOs are handled correctly, and their keys are never updated.)
Complex Code or Requirements
This fix to the tree reading code is compatible with the permanent fix in PR #7392: changing to the key format to an empty key, so the trees get overwritten rather than deleted and re-inserted.
Solution
Review
This PR should probably get in before the 1.3.0 release, because it fixes a panic bug.
Reviewer Checklist
Follow Up Work
Permanent format fix in PR #7392.