-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(release): Add "wait for a full sync" to the release checklist and ticket template #7612
Conversation
Turns out this is needed anyway, we just found a performance issue right before the release because of an auto-opened full sync ticket #7618. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this changes are needed to the release process so thank you for making them.
I left a few minor optional suggestions, feel free to discard them.
Co-authored-by: Alfredo Garcia <[email protected]>
Thank you for the suggestions! |
Motivation
We're testing the state format in CI, but some code paths don't get tested until we do a full sync.
So we need to wait for a full sync between the last state change and the release. (Or run a manual full sync.)
Complex Code or Requirements
It's not clear which code changes can change the state format, so it might be easier just to say "anything in zebra-state or zebra-chain".
Solution
Update the release checklist with this step
Update the release ticket template with this step
Review
Ideally this should be merged before we open the ticket for the next release.
This is for discussion at the Zebra sync.
Reviewer Checklist