Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(docs): Add changelog entry for stable mining feature #7788

Merged
merged 5 commits into from
Oct 20, 2023

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Oct 19, 2023

Motivation

We want to talk about stabilising mining RPCs in the changelog for the next release.

The mining part of the README also needs an update.

This is a follow-up to ticket #7361.

Review

This is a low priority documentation change. Technically it blocks the next release, but it should be merged long before then.

Reviewer Checklist

  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added A-docs Area: Documentation P-Low ❄️ A-rpc Area: Remote Procedure Call interfaces C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Oct 19, 2023
@teor2345 teor2345 self-assigned this Oct 19, 2023
@teor2345 teor2345 requested a review from a team as a code owner October 19, 2023 21:19
@teor2345 teor2345 requested review from upbqdn and removed request for a team October 19, 2023 21:19
@github-actions github-actions bot added the C-feature Category: New features label Oct 19, 2023
upbqdn
upbqdn previously approved these changes Oct 19, 2023
Copy link
Member

@upbqdn upbqdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should also mention that miners will still need to run zcashd for rewards distribution.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@teor2345
Copy link
Contributor Author

I wonder if we should also mention that miners will still need to run zcashd for rewards distribution.

I think it depends on the mining software. Some of them make their own coinbase transactions that distribute rewards, or using their own miner address.

What do you think about commit 44a5f9f?
(The README needed an update for mining.)

We could copy some of that wording into the CHANGELOG?

arya2
arya2 previously approved these changes Oct 20, 2023
README.md Outdated Show resolved Hide resolved
Co-authored-by: Arya <[email protected]>
@mergify mergify bot merged commit 92f4732 into main Oct 20, 2023
72 checks passed
@mergify mergify bot deleted the changelog-mining branch October 20, 2023 17:31
@teor2345 teor2345 mentioned this pull request Nov 5, 2023
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation A-rpc Area: Remote Procedure Call interfaces C-feature Category: New features C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants