Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(miner): Simplify concurrency in experimental internal miner #8174

Closed
wants to merge 3 commits into from

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Jan 19, 2024

Motivation

This PR is not yet ready for review.

It should resolve the follow up work in #8136, resolve some TODOs, and simplify the concurrent logic once completed.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?
For significant changes:
  • Is there a summary in the CHANGELOG?
  • Can these changes be split into multiple PRs?

If a checkbox isn't relevant to the PR, mark it as done.

Solution

  • Adds an is_closed() method to WatchReceiver
  • Adds awaits in mining solver tasks so only generate_block_template is responsible for waiting when the chain is changing rapidly or blocks have been submitted successfully

Testing

This will require manual testing like that in #8136

Review

This PR is not yet ready for review.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@arya2 arya2 added C-enhancement Category: This is an improvement A-concurrency Area: Async code, needs extra work to make it work properly. P-Optional ✨ labels Jan 19, 2024
@arya2 arya2 self-assigned this Jan 19, 2024
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Jan 19, 2024
@oxarbitrage oxarbitrage added do-not-merge Tells Mergify not to merge this PR and removed do-not-merge Tells Mergify not to merge this PR labels Jan 23, 2024
@arya2 arya2 closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-concurrency Area: Async code, needs extra work to make it work properly. C-enhancement Category: This is an improvement C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Optional ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants