-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(mining): Restores parts of the internal-miner feature for use on Regtest #8506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment::from_bytes()`
…ion isn't checked
arya2
added
I-usability
Zebra is hard to understand or use
NU-6
Network Upgrade: NU6 specific tasks
C-testing
Category: These are tests
P-Medium ⚡
labels
May 4, 2024
github-actions
bot
added
C-feature
Category: New features
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
labels
May 4, 2024
oxarbitrage
reviewed
May 10, 2024
arya2
force-pushed
the
regtest-internal-miner
branch
from
May 10, 2024 13:40
40e6081
to
752949e
Compare
oxarbitrage
approved these changes
May 10, 2024
@Mergifyio refresh |
✅ Pull request refreshed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-feature
Category: New features
C-testing
Category: These are tests
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
I-usability
Zebra is hard to understand or use
NU-6
Network Upgrade: NU6 specific tasks
P-Medium ⚡
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want Zebra to have an internal miner for use on Testnet and Regtest.
Part of #8183.
Depends-On: #8505.
PR Author Checklist
Check before marking the PR as ready for review:
For significant changes:
If a checkbox isn't relevant to the PR, mark it as done.
Solution
Restores parts of the internal-miner feature and uses a empty
Solution
instead of the equihash tromp solver.Testing
Manually tested.
Review
Anyone can review.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.