Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(mining): Restores parts of the internal-miner feature for use on Regtest #8506

Merged
merged 7 commits into from
May 10, 2024

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented May 4, 2024

Motivation

We want Zebra to have an internal miner for use on Testnet and Regtest.

Part of #8183.

Depends-On: #8505.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?
For significant changes:
  • Is there a summary in the CHANGELOG?
  • Can these changes be split into multiple PRs?

If a checkbox isn't relevant to the PR, mark it as done.

Solution

Restores parts of the internal-miner feature and uses a empty Solution instead of the equihash tromp solver.

Testing

Manually tested.

Review

Anyone can review.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@arya2 arya2 added I-usability Zebra is hard to understand or use NU-6 Network Upgrade: NU6 specific tasks C-testing Category: These are tests P-Medium ⚡ labels May 4, 2024
@arya2 arya2 added this to the Regtest Network support milestone May 4, 2024
@arya2 arya2 self-assigned this May 4, 2024
@arya2 arya2 requested review from a team as code owners May 4, 2024 02:05
@arya2 arya2 requested review from oxarbitrage and removed request for a team May 4, 2024 02:05
@github-actions github-actions bot added C-feature Category: New features C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels May 4, 2024
@arya2 arya2 added the do-not-merge Tells Mergify not to merge this PR label May 4, 2024
@mpguerra
Copy link
Contributor

mpguerra commented May 7, 2024

@arya2 will this close #8183 ?

@arya2
Copy link
Contributor Author

arya2 commented May 7, 2024

@arya2 will this close #8183 ?

Not yet. This doesn't mine valid equihash solutions, so it won't work on the default testnet, and it's single-threaded since multiple threads are unnecessary while it skips checking the proof of work.

@oxarbitrage oxarbitrage removed the do-not-merge Tells Mergify not to merge this PR label May 7, 2024
Base automatically changed from allow-canopy-on-regtest to main May 8, 2024 14:46
@oxarbitrage
Copy link
Contributor

@Mergifyio refresh

Copy link
Contributor

mergify bot commented May 10, 2024

refresh

✅ Pull request refreshed

@mergify mergify bot merged commit a6569d4 into main May 10, 2024
137 checks passed
@mergify mergify bot deleted the regtest-internal-miner branch May 10, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: New features C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-usability Zebra is hard to understand or use NU-6 Network Upgrade: NU6 specific tasks P-Medium ⚡
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants