Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): do not silently fail integration tests #8631

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

gustavovalverde
Copy link
Member

@gustavovalverde gustavovalverde commented Jun 20, 2024

Motivation

After #8594 some test might silently fail as a job dependency was removed for failure-issue, but it was still in the needs list.

Solution

Comment the non existent dependency from failure-issue

Tests

  • Integration tests should run here without issue

PR Author's Checklist

  • The PR name will make sense to users.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@gustavovalverde gustavovalverde added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles I-integration-fail Continuous integration fails, including build and test failures P-Critical 🚑 labels Jun 20, 2024
@gustavovalverde gustavovalverde self-assigned this Jun 20, 2024
@gustavovalverde gustavovalverde requested a review from a team as a code owner June 20, 2024 12:48
@gustavovalverde gustavovalverde requested review from oxarbitrage and removed request for a team June 20, 2024 12:48
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Jun 20, 2024
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the fix. It is enough to have the test commented out instead of just being removed ? Please also note this might be restored in the context of #8585

Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I left a note in #8585 about reverting this if/when the test is restored so we don't forget.

mergify bot added a commit that referenced this pull request Jun 20, 2024
@mergify mergify bot merged commit df10c75 into main Jun 20, 2024
127 checks passed
@mergify mergify bot deleted the fix-ci-workflow branch June 20, 2024 22:26
@gustavovalverde
Copy link
Member Author

It is enough to have the test commented out instead of just being removed ?

@oxarbitrage I commented the test from the list, instead of removing it, as the test itself was commented out and not removed. It was, mainly, to keep it consistent with the previous change

@oxarbitrage
Copy link
Contributor

It is enough to have the test commented out instead of just being removed ?

@oxarbitrage I commented the test from the list, instead of removing it, as the test itself was commented out and not removed. It was, mainly, to keep it consistent with the previous change

Got it, thank you.

@upbqdn upbqdn mentioned this pull request Jun 28, 2024
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-integration-fail Continuous integration fails, including build and test failures P-Critical 🚑
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants