-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): do not silently fail integration tests #8631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the fix. It is enough to have the test commented out instead of just being removed ? Please also note this might be restored in the context of #8585
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, I left a note in #8585 about reverting this if/when the test is restored so we don't forget.
@oxarbitrage I commented the test from the list, instead of removing it, as the test itself was commented out and not removed. It was, mainly, to keep it consistent with the previous change |
Got it, thank you. |
Motivation
After #8594 some test might silently fail as a job dependency was removed for
failure-issue
, but it was still in theneeds
list.Solution
Comment the non existent dependency from
failure-issue
Tests
PR Author's Checklist
PR Reviewer's Checklist