tests(scanner): Move zebra scanner tests to binary

[oxarbitrage]

Motivation

We moved the scanner into a new binary in #8608 . We also removed the scanner functionality from zebrad and commented out tests in #8594

Now is time to get the tests we commented out back, in the context of the new binary.

Close #8593

Part of #8585

Solution

Add tests to zebra scanner binary.

Follow-up Work

• I think we can add a test close to the tip for TrustedChainSync functionality introduced in change(rpc): Adds a TrustedChainSync struct for keeping up with Zebra's non-finalized best chain from a separate process #8596 to finish with the scanner tests coverage and complete Testing the new zebra-scanner binary #8585

PR Author's Checklist

• The PR name will make sense to users.
• The PR provides a CHANGELOG summary.
• The solution is tested.
• The documentation is up to date.
• The PR has a priority label.

PR Reviewer's Checklist

• The PR Author's checklist is complete.
• The PR resolves the issue.

[mpguerra]

Does this PR also cover #8593 ?

[oxarbitrage]

Does this PR also cover #8593 ?

Yes, this PR will close that issue. I added that to the description. I am rebasing now.

[arya2]

This looks good!

We should uncomment the scan-start-where-left-test CI job in this PR too (it was commented out here)

I'm not sure how reliable it is to define a CARGO_BIN_EXE_zebrad env var outside the build process. If it's not very reliable, I'd suggest adding a scanner binary in zebrad as well and moving the tests here that rely on the zebrad binary back to the zebrad acceptance tests (it's nicer to have these tests here but it seems much more difficult to add a zebrad binary in zebra-scan).

Update: It seems very easy to add a zebrad binary to zebra-scan, I would suggest doing that instead if it's valuable to have the CARGO_BIN_EXE_zebrad environment variable .

[arya2]

@oxarbitrage The shielded-scan feature was partially removed from zebrad, but there are still some uses of it causing test failures.

[oxarbitrage]

@oxarbitrage The shielded-scan feature was partially removed from zebrad, but there are still some uses of it causing test failures.

Ok, ill check that out. Thanks.

[oxarbitrage]

Update: Need more work related to moving this test https://github.com/ZcashFoundation/zebra/blob/main/zebrad/tests/common/shielded_scan/scan_task_commands.rs out of zebrad. I am still working on it, changing the PR to draft until that is sorted.

[arya2]

This looks good!