Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(actions): run get-disk-name on all workflow events #8942

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

gustavovalverde
Copy link
Member

@gustavovalverde gustavovalverde commented Oct 17, 2024

Motivation

While testing in #8908, a testing condition was not removed and merged into the main branch, which skips a required job for the cached states images to be found and attached to the instances.

Identified here: https://github.com/ZcashFoundation/zebra/actions/runs/11385606467/job/31676320538

Solution

  • Remove the github.event_name == 'workflow_dispatch' condition that was used for testing in the PR

Tests

  • All tests should pass here

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@gustavovalverde gustavovalverde added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles I-integration-fail Continuous integration fails, including build and test failures P-Critical 🚑 labels Oct 17, 2024
@gustavovalverde gustavovalverde requested a review from a team as a code owner October 17, 2024 14:59
@gustavovalverde gustavovalverde requested review from arya2 and removed request for a team October 17, 2024 14:59
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Oct 17, 2024
@mergify mergify bot merged commit a182ffe into main Oct 17, 2024
102 checks passed
@mergify mergify bot deleted the fix-cached-disk-logic branch October 17, 2024 15:22
@upbqdn upbqdn mentioned this pull request Oct 25, 2024
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-integration-fail Continuous integration fails, including build and test failures P-Critical 🚑
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants