Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): Update documents for cookie auth where needed #8965

Merged
merged 3 commits into from
Oct 25, 2024
Merged

fix(docs): Update documents for cookie auth where needed #8965

merged 3 commits into from
Oct 25, 2024

Conversation

oxarbitrage
Copy link
Contributor

@oxarbitrage oxarbitrage commented Oct 24, 2024 •
edited by arya2
Loading

Motivation

We added the cookie auth method to our RPC endpoint in #8900

We want to update the zebra book documentation to enable/disable/use it where needed.

Solution

  • Update ligthwalletd and mining docs.

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@oxarbitrage oxarbitrage added A-docs Area: Documentation A-rpc Area: Remote Procedure Call interfaces P-Medium ⚡ labels Oct 24, 2024
@oxarbitrage oxarbitrage requested a review from a team as a code owner October 24, 2024 21:46
@oxarbitrage oxarbitrage requested review from arya2 and removed request for a team October 24, 2024 21:46
arya2
arya2 reviewed Oct 24, 2024
View reviewed changes
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

book/src/user/lightwalletd.md Outdated Show resolved Hide resolved
book/src/user/lightwalletd.md Outdated Show resolved Hide resolved
arya2
arya2 previously approved these changes Oct 24, 2024
View reviewed changes
@upbqdn upbqdn added C-security Category: Security issues P-High 🔥 and removed P-Medium ⚡ labels Oct 25, 2024
mergify bot added a commit that referenced this pull request Oct 25, 2024
@mergify
Merge of #8965
61fd1c9
@mergify mergify bot mentioned this pull request Oct 25, 2024
Closed
@mergify mergify bot merged commit 8f887f2 into main Oct 25, 2024
95 checks passed
@mergify mergify bot deleted the document-cookie-auth branch October 25, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upbqdn upbqdn upbqdn approved these changes

@arya2 arya2 arya2 left review comments

Assignees
No one assigned
Labels
A-docs Area: Documentation A-rpc Area: Remote Procedure Call interfaces C-security Category: Security issues P-High 🔥
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oxarbitrage @arya2 @upbqdn