change(deps): Use ECC deps with activation height for NU6 #8978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to enable the `legacy-api` feature of `incrementalmerkletree` to be able to serialize note commitment trees using an old serialization format for the `z_gettreestate` RPC.
upbqdn
added
A-dependencies
github-actions
bot
added
the
extra-reviews
upbqdn
force-pushed
the
remove-dep-patches
branch
from
b49bfb2
to
e52915c
Compare
arya2
approved these changes
Oct 28, 2024
|
Looks like the checkpoint job didn't find a cached state: https://github.com/ZcashFoundation/zebra/actions/runs/11559820540/job/32175800783?pr=8978#step:15:3351 Update: I'm running the Update: The test passes locally, I think we should admin merge this if it times out again. Increasing the timeout should help otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Zebra 2.0.0 uses ECC deps that don't have NU6 Mainnet activation height set. We must use new versions of these crates that have the activation height set.
Solution
legacy-apifeature ofincrementalmerkletreeto be able to serialize note commitment trees using an old serialization format for thez_gettreestateRPC.Tests
No new tests.
Follow-up Work