Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add(build): Add a rust-toolchain.toml file #8985

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Nov 1, 2024

Motivation

Cargo should automatically use the right version of rustc when a rust-toolchain.toml file is present.

Specifications & References

https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file

Solution

Adds a rust-toolchain.toml that sets the channel to the latest stable release.

Tests

This was used for convenience in an early version of zebra-launcher that relied on the nightly release for artifact dependencies and worked as expected.

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@arya2 arya2 added A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Optional ✨ labels Nov 1, 2024
@arya2 arya2 self-assigned this Nov 1, 2024
@arya2 arya2 requested a review from a team as a code owner November 1, 2024 03:53
@arya2 arya2 requested review from upbqdn and removed request for a team November 1, 2024 03:53
@mergify mergify bot merged commit 83921bc into main Nov 1, 2024
95 checks passed
@mergify mergify bot deleted the add-rust-toolchain-toml branch November 1, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup C-enhancement Category: This is an improvement C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Optional ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants