Golangci config and workflow

.github/workflows/golangci-lint.yml

@@ -0,0 +1,23 @@
+name: golangci-lint
+on:
+  push:
+    branches: ["master","dev"]  
+  pull_request:
+    branches: ["master","dev"]
+jobs:
+  golangci:
+    name: Lint
+    runs-on: ubuntu-latest
+    steps:
+      - name: Setup Go
+        uses: actions/setup-go@v2
+        with:
+          go-version: 1.19
+      - uses: actions/checkout@v3
+      - name: Tidy
+        run: go mod tidy
+      - name: Lint
+        uses: golangci/golangci-lint-action@v3
+        with:
+          version: v1.46.2
+          args: --timeout=3m

configs/.golangci.yml

@@ -0,0 +1,2 @@
+issues:
+  new: true

main.go

@@ -8,14 +8,8 @@ import (
 	"zestream-server/configs"
 	"zestream-server/constants"
 	"zestream-server/routes"
-	"zestream-server/service"
 )
 
-func dev() {
-	// utils.Fetch("https://commondatastorage.googleapis.com/gtv-videos-bucket/sample/WeAreGoingOnBullrun.mp4", "Test.mp4")
-	service.GenerateDash("Test.mp4", constants.WaterMark{FileName: "TestWatermark.png", Dimension: map[string]int{"x": 64, "y": -1}, Position: map[string]int{"x": 10, "y": 10}}, false)
-}
-
 func main() {
 	configs.LoadEnv()
 
@@ -45,5 +39,8 @@ func main() {
 		fmt.Println(err)
 	}
 
-	r.Run(":" + port)
+	err = r.Run(":" + port)
+	if err != nil {
+		fmt.Println(err)
+	}
 }

service/dash.go

@@ -68,7 +68,7 @@ func generateThumbnailFiles(targetFile string, outputPath string, wg *sync.WaitG
 }
 
 func generateMultiBitrateAudio(targetFile string, outputFile string, fileType constants.FILE_TYPE, wg *sync.WaitGroup) {
-	ffmpeg.Input(targetFile, ffmpeg.KwArgs{
+	err := ffmpeg.Input(targetFile, ffmpeg.KwArgs{
 		constants.AudioKwargs[constants.HWAccel]: constants.FFmpegConfig[constants.HWAccel],
 	}).
 		Output(outputFile, ffmpeg.KwArgs{
@@ -78,13 +78,17 @@ func generateMultiBitrateAudio(targetFile string, outputFile string, fileType co
 			constants.AudioKwargs[constants.VideoExclusion]:    constants.FFmpegConfig[constants.VideoExclusion],
 		}).
 		OverWriteOutput().ErrorToStdOut().Run()
+	if err != nil {
+		m := "error generating multi bitrate audio"
+		log.Println(m, err)
+	}
 
 	wg.Done()
 }
 
 func generateMultiBitrateVideo(targetFile string, outputFile string, fileType constants.FILE_TYPE, withWatermark bool, watermark constants.WaterMark, wg *sync.WaitGroup) {
 
-	getInput(targetFile, withWatermark, watermark).
+	err := getInput(targetFile, withWatermark, watermark).
 		Output(outputFile, ffmpeg.KwArgs{
 			constants.VideoKwargs[constants.Preset]:         constants.FFmpegConfig[constants.Preset],
 			constants.VideoKwargs[constants.Tune]:           constants.FFmpegConfig[constants.Tune],
@@ -99,12 +103,17 @@ func generateMultiBitrateVideo(targetFile string, outputFile string, fileType co
 		ErrorToStdOut().
 		Run()
 
+	if err != nil {
+		m := "error generating multi bitrate video"
+		log.Println(m, err)
+	}
+
 	wg.Done()
 }
 
 // generateThumbnail generates a thumbnail at given timestamp, from the target file and write it to output file
 func generateThumbnails(targetFile string, outputFile string, timeStamp string, wg *sync.WaitGroup) {
-	ffmpeg.Input(targetFile).
+	err := ffmpeg.Input(targetFile).
 		Output(outputFile, ffmpeg.KwArgs{
 			constants.VideoKwargs[constants.ScreenShot]:  timeStamp,
 			constants.VideoKwargs[constants.VideoFrames]: constants.FFmpegConfig[constants.VideoFrames],
@@ -113,6 +122,11 @@ func generateThumbnails(targetFile string, outputFile string, timeStamp string,
 		ErrorToStdOut().
 		Run()
 
+	if err != nil {
+		m := "error generating thumbnail"
+		log.Println(m, err)
+	}
+
 	wg.Done()
 }
 

utils/fetch_test.go

@@ -28,5 +28,8 @@ func TestFetch(t *testing.T) {
 		t.Error("want true, got", isFileDownloaded)
 	}
 
-	utils.DeleteFiles(pathName)
+	err = utils.DeleteFiles(pathName)
+	if err != nil {
+		t.Fatal(err)
+	}
 }

utils/kafka.go

@@ -20,7 +20,10 @@ func PublishMessage(kafkaURI, topic string, message string) (string, error) {
 		return m, err
 	}
 
-	conn.SetWriteDeadline(time.Now().Add(10 * time.Second))
+	if err := conn.SetWriteDeadline(time.Now().Add(10 * time.Second)); err != nil {
+		m = "failed to set write deadline"
+		log.Println(m, err)
+	}
 	_, err = conn.WriteMessages(
 		kafka.Message{Value: []byte(message)},
 	)