Skip to content

Commit

Permalink
removed signing
Browse files Browse the repository at this point in the history
  • Loading branch information
Zedonboy committed Jan 30, 2025
1 parent 6005c53 commit bf80022
Showing 1 changed file with 43 additions and 43 deletions.
86 changes: 43 additions & 43 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,64 +48,64 @@ jobs:
- name: Build App Bundle
run: flutter build appbundle --release --build-name=${{github.event.inputs.tag_name}}

- name: Setup Android SDK
uses: android-actions/setup-android@v3
# - name: Setup Android SDK
# uses: android-actions/setup-android@v3

- name: Sign APK
run: |
echo "${{ secrets.ANDROID_KEYSTORE }}" | base64 -d > keystore.jks
echo "${{ secrets.ANDROID_KEYSTORE_PASSWORD }}" > keystore_password.txt
echo "${{ secrets.ANDROID_KEY_ALIAS }}" > key_alias.txt
echo "${{ secrets.ANDROID_KEY_PASSWORD }}" > key_password.txt
# - name: Sign APK
# run: |
# echo "${{ secrets.ANDROID_KEYSTORE }}" | base64 -d > keystore.jks
# echo "${{ secrets.ANDROID_KEYSTORE_PASSWORD }}" > keystore_password.txt
# echo "${{ secrets.ANDROID_KEY_ALIAS }}" > key_alias.txt
# echo "${{ secrets.ANDROID_KEY_PASSWORD }}" > key_password.txt

LATEST_BUILD_TOOLS=$(ls $ANDROID_HOME/build-tools | sort -V | tail -n 1)
ZIPALIGN="$ANDROID_HOME/build-tools/$LATEST_BUILD_TOOLS/zipalign"
# LATEST_BUILD_TOOLS=$(ls $ANDROID_HOME/build-tools | sort -V | tail -n 1)
# ZIPALIGN="$ANDROID_HOME/build-tools/$LATEST_BUILD_TOOLS/zipalign"

for apk in build/app/outputs/flutter-apk/*-release.apk; do
[ -f "$apk" ] || continue
# for apk in build/app/outputs/flutter-apk/*-release.apk; do
# [ -f "$apk" ] || continue

filename=$(basename "$apk")
signed_name="${filename%.*}-signed.apk"
# filename=$(basename "$apk")
# signed_name="${filename%.*}-signed.apk"

jarsigner -verbose \
-keystore keystore.jks \
-storepass $(cat keystore_password.txt) \
-keypass $(cat key_password.txt) \
"$apk" \
$(cat key_alias.txt)

$ZIPALIGN -v 4 \
"$apk" \
"build/app/outputs/flutter-apk/$signed_name"
done
- name: Sign App Bundle
run: |
# We can reuse the keystore and password files from APK signing
jarsigner -verbose \
-keystore keystore.jks \
-storepass $(cat keystore_password.txt) \
-keypass $(cat key_password.txt) \
build/app/outputs/bundle/release/app-release.aab \
$(cat key_alias.txt)
# jarsigner -verbose \
# -keystore keystore.jks \
# -storepass $(cat keystore_password.txt) \
# -keypass $(cat key_password.txt) \
# "$apk" \
# $(cat key_alias.txt)

# $ZIPALIGN -v 4 \
# "$apk" \
# "build/app/outputs/flutter-apk/$signed_name"
# done
# - name: Sign App Bundle
# run: |
# # We can reuse the keystore and password files from APK signing
# jarsigner -verbose \
# -keystore keystore.jks \
# -storepass $(cat keystore_password.txt) \
# -keypass $(cat key_password.txt) \
# build/app/outputs/bundle/release/app-release.aab \
# $(cat key_alias.txt)

# Create a directory for the signed bundle
mkdir -p build/app/outputs/bundle/release/signed
# # Create a directory for the signed bundle
# mkdir -p build/app/outputs/bundle/release/signed

# Move the signed bundle
mv build/app/outputs/bundle/release/app-release.aab \
build/app/outputs/bundle/release/signed/app-release-signed.aab
# # Move the signed bundle
# mv build/app/outputs/bundle/release/app-release.aab \
# build/app/outputs/bundle/release/signed/app-release-signed.aab

- name: Upload Signed APK as artifact
uses: actions/upload-artifact@v4
with:
name: signed-apk
path: build/app/outputs/flutter-apk/*-signed.apk
path: build/app/outputs/flutter-apk/*-release.apk

- name: Upload App Bundle as artifact
uses: actions/upload-artifact@v4
with:
name: app-release.aab
path: build/app/outputs/bundle/release/signed/app-release-signed.aab
path: build/app/outputs/bundle/release/signed/app-release.aab

release:
runs-on: ubuntu-latest
Expand All @@ -130,7 +130,7 @@ jobs:
## Release Notes
${{ github.event.inputs.release_note }}
files: |
build/apk/*-signed.apk
build/aab/app-release-signed.aab
build/apk/*-release.apk
build/aab/app-release.aab
tag_name: ${{ github.event.inputs.tag_name }} # Use the dynamic tag_name input
name: Release ${{ github.event.inputs.tag_name }} # Use the dynamic tag_name input

0 comments on commit bf80022

Please sign in to comment.