-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow searching replays by is-MM and rating type. #2787
Conversation
553f559
to
8312446
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor suggestions after glancing it over.
Good point.
That seems like a reasonable take to me, but I'd prefer to tackle it in a separate PR at a later date.
It is, but all the other filters have a similar conditional around them to check whether filtering on that category is active so I think this makes the file as a whole easier to read, even if it's a little weird in the context of that specific switch statement.
dotnet/efcore#2852 suggests that HasFlag does have a translation as of 2016. Certainly it did not throw an error like b.IsRatedMatch() did when I used it in the same place, and I would expect that to have worked if I had mistakenly added a ToList earlier. Can you confirm that this is a problem, and if so what I'm missing? (In particular, if zkinfra has to be able to work using an old version of LINQ then that would be important to know going forward.) |
Also displays (primary) rating type on each replay page to non-admins.