Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

At First Light: Remove duplicate step #1953

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vmgi
Copy link
Contributor

@vmgi vmgi commented Jan 19, 2025

talkToAtza = new NpcStep(this, NpcID.ATZA, new WorldPoint(1696, 3063, 0),
			"Talk to Atza in one of the buildings outside Civitas illa Fortis' south wall, west of the general store.",
			furSample);
		talkToAtzaAfterHandingFur = new NpcStep(this, NpcID.ATZA, new WorldPoint(1696, 3063, 0),
			"Talk to Atza in one of the buildings outside Civitas illa Fortis' south wall, west of the general store.");
		talkToAtza.addSubSteps(talkToAtzaAfterHandingFur);

Problem:

'talkToAtza' is given a sub-step whose function is a duplicate. This step occurring twice makes the helper appear behind.

Solution:

Remove the and delete the sub-step.

After some sleuthing this is what I was able to come up with, I could have a complete misunderstanding of how things work though.
Potentially closes #1952

@pajlada
Copy link
Collaborator

pajlada commented Jan 19, 2025

I haven't done At First Light on one of my alts so I can do it in a bit and test your change alongside a polish pass, thank you!

Copy link
Collaborator

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this change and everything went smoothly for me

Could you update your PR title to match what's being changed? (e.g. At First Light: Remove duplicate step)

@vmgi
Copy link
Contributor Author

vmgi commented Jan 29, 2025

Sorry, just seeing this. That's great! Yes, absolutely. :-)

@vmgi vmgi changed the title At First Light #1952 At First Light: Remove duplicate step Jan 29, 2025
Copy link
Owner

@Zoinkwiz Zoinkwiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually how making something a substep works is that it means the substep will cause the parent step to highlight in the sidebar. In this case the substep exists as there's a point where you don't need the fur, and we don't want to incorrectly guide the player that they need more fur when they don't.

Is the issue that the sidebar didn't correctly update to move to the talkToAtza step when the talkToAtzaAfterHandingFur step was active? Did it actively jump back to a step even earlier, and if so which one? If either of those happened I think that's an issue elsewhere, no with this here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

At First Light
3 participants