fix onboarding first check

a-type · May 28, 2024 · 163be38 · 163be38
1 parent b14c735
commit 163be38
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 22 deletions.
diff --git a/apps/gnocchi/web/src/components/groceries/items/GroceryListItem.tsx b/apps/gnocchi/web/src/components/groceries/items/GroceryListItem.tsx
@@ -72,12 +72,11 @@ export interface GroceryListItemProps {
   isDragActive?: boolean;
   style?: CSSProperties;
   menuProps?: any;
-  first?: boolean;
 }
 
 export const GroceryListItem = forwardRef<HTMLDivElement, GroceryListItemProps>(
   function GroceryListItem(
-    { item, isDragActive, menuProps, className, first, ...rest },
+    { item, isDragActive, menuProps, className, ...rest },
     ref,
   ) {
     const { purchasedAt, comment, id, food, textOverride } =
@@ -198,18 +197,14 @@ export const GroceryListItem = forwardRef<HTMLDivElement, GroceryListItemProps>(
               // onContextMenu={preventDefault}
               {...menuProps}
             >
-              {first ? (
-                <OnboardingTooltip
-                  onboarding={categorizeOnboarding}
-                  step="categorize"
-                  content="Tap and hold to change category"
-                  disableNext
-                >
-                  <DragHandleDots2Icon className="text-gray-5 hover:text-white" />
-                </OnboardingTooltip>
-              ) : (
-                <DragHandleDots2Icon className="text-gray-5 hover:text-white" />
-              )}
+              <OnboardingTooltip
+                onboarding={categorizeOnboarding}
+                step="categorize"
+                content="Tap and hold to change category"
+                disableNext
+              >
+                <Icon name="grabby" className="text-gray-5" />
+              </OnboardingTooltip>
             </div>
           </div>
           <CollapsibleTrigger asChild>

diff --git a/apps/gnocchi/web/src/onboarding/firstTimeOnboarding.ts b/apps/gnocchi/web/src/onboarding/firstTimeOnboarding.ts
@@ -1,6 +1,3 @@
 import { createOnboarding } from '@biscuits/client';
 
-export const firstTimeOnboarding = createOnboarding('firstTime', [
-  'welcome',
-  'settings',
-]);
+export const firstTimeOnboarding = createOnboarding('firstTime', ['welcome']);
diff --git a/packages/client/src/components/onboarding.tsx b/packages/client/src/components/onboarding.tsx
@@ -82,10 +82,15 @@ export function createOnboarding<Steps extends StringTuple>(
     // a unique ID for this invocation of this hook. useful if there
     // are multiple mounted components using this same hook and name.
     const id = useId();
-    if (stepClaims[name] === undefined) {
-      stepClaims[name] = id;
-    }
-    const hasClaim = true; // stepClaims[name] === id;
+    const hasClaim = stepClaims[name] === id;
+    useEffect(() => {
+      if (!stepClaims[name]) {
+        stepClaims[name] = id;
+        return () => {
+          delete stepClaims[name];
+        };
+      }
+    }, [id]);
 
     const active = useSnapshot(state).active;