Use iterators to traverse through strings (#719)

Documentation says at <https://docs.wxwidgets.org/latest/classwx_string.html> that accessing the character by index should be avoided.
aardappel · Sep 20, 2024 · 8a86a1a · 8a86a1a
1 parent 6726edc
commit 8a86a1a
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/text.h b/src/text.h
@@ -57,12 +57,13 @@ struct Text {
 
     wxString htmlify(wxString &str) {
         wxString r;
-        loop(i, str.Len()) {
-            switch (str[i].GetValue()) {
+        for(auto cref : str) {
+            wxChar c = cref.GetValue();
+            switch(c) {
                 case '&': r += L"&amp;"; break;
                 case '<': r += L"&lt;"; break;
                 case '>': r += L"&gt;"; break;
-                default: r += str[i];
+                default: r += c;
             }
         }
         return r;