Slightly modernise HTML export #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for modernizing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current doctype triggers quirks mode, which is for pre-IE6 compatibility.
I tested all 3 HTML export (table, bullet, outline) of tutorial.cts to make sure they look the same in standards mode (in Firefox 115 on Linux).
The table style looks 100% the same, pixel-perfect. The outline style has negligible alignment differences (some text looks higher by 1px).
The bullet style has 1 visible difference: in quirks mode, nested lists (
li > ul) with no text in the parent li has extra padding on top, which I would say is a bug/unintended (from TS' point of view), since there is no extra padding anywhere else.The
font-weight: normalis added to reset the font weight in nested tables, because standards mode properly inherits font styles in tables which quirks mode did not.Benefit of this change is users who edit the HTML export (e.g. to apply additional styling) should have more predictable modern behaviour.