Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitignore script folder #487

Closed
wants to merge 1 commit into from

Conversation

AntonBogun
Copy link
Contributor

Add TS/scripts to gitignore since if there are any user scripts in there they will appear on git status as untracked.
Any new example scripts can be added directly, and a nested git repository can be setup within the scripts folder to have source control over user scripts.

@aardappel
Copy link
Owner

There are files in there that are tracked by git, so this is not a great idea.

Not sure what the right solution is, maybe a scripts/user folder?

@AntonBogun
Copy link
Contributor Author

Existing files in the repository do not stop being tracked, in fact I think it even allows adding them if they are changed.
The problem with doing the user folder is that i don't think treesheets will add them as scripts that can be used. I suppose it could be changed in code to support this, but I don't see why simply ignoring the whole scripts folder is a bad idea.

@aardappel
Copy link
Owner

Yeah, still not great as you won't see new files.

This is only an issue for people who are actively using TreeSheets from a git development dir, so I don't think is a good tradeof.

@aardappel
Copy link
Owner

Closing for now, until new opinions / new changes come in..

@aardappel aardappel closed this Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants