Update scrollbar after zoom on wxGTK #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiolo
force-pushed
the
update-scrollbar-after-zoom-wxgtk
branch
2 times, most recently
from
9230409
to
42fb869
Compare
tobiolo
force-pushed
the
update-scrollbar-after-zoom-wxgtk
branch
from
42fb869
to
ed8865c
Compare
aardappel
reviewed
Aug 27, 2023
| @@ -745,6 +745,15 @@ struct Document { | |||
| #ifndef __WXMSW__ | |||
| if (sw) sw->Refresh(false); | |||
| #endif | |||
| #ifdef __WXGTK__ | |||
| if (sw) { | |||
| // wxWidgets (wxGTK) does not always automatically update the scrollbar | |||
There was a problem hiding this comment.
This calls both the above Refresh and your new code GTK, are you sure both are needed?
There was a problem hiding this comment.
Yes, unfortunately. I tested it with a TreeSheets documents with nested grids and this is the way I found out to remove the bug that the scrollbar is at default position (0,0) when zoomed out instead of the correct scrollbar position mirroring the position of the selection on the canvas.
There was a problem hiding this comment.
Bug demonstrated:
Peek.2023-08-27.17-50.mp4
There was a problem hiding this comment.
With this PR
Peek.2023-08-27.17-52.mp4
There was a problem hiding this comment.
@aardappel Do you agree with the rationale behind this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.