Comment is no longer valid #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These kinds of fixes are not available in the minimum wxWidgets version we support yet, right? So some people building or even looking at the code may still have the problem. Thus, to be totally correct, it be better to say that this is a problem which was fixed in $date version of wxWidgets. Only when we require a minimum version of wxWidgets to build against that does not have the bug should the code pretend there is no problem. |
|
Thanks for your feedback. Then it is really better to wait for the next release version. I would like to keep this PR open as a reminder then. |
Issue solved with wxWidgets/wxWidgets#24505 But it makes sense to keep the changes and not to pack the data objects into a composite object only to unpack it later.
tobiolo
force-pushed
the
delete-comment
branch
from
f2dca19
to
72da5d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue solved with wxWidgets/wxWidgets#24505
But it makes sense to keep the changes and not to pack the data objects into a composite object only to unpack it later.