Update bolt data source with test and dht with tests and enhancements #13
+360
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added some comments to datastore_bolt.go
* the code has more test coverage * there is a very small number of backwards compatibility breaks that I think were necessary because dht (lower case) was exported as a return type, this has been changed to DHT fix for GetSlotVsNodes so that a copy of the slots vs nodes is returned so that the caller cannot modify the returned map
|
I would like to work on the consensus section and fsm stuff next, to cover with tests and add more functionality. Happy to refactor this pr if needed. |
|
Sure. You can create a separate PR for the same. I will review this PR by tomorrow. |
* update ignored files: user specific files * Update ignored files: ignore all appearances of OS generated files
* Resolving merge conflicts
* Resolving merge conflicts
* the code has more test coverage * there is a very small number of backwards compatibility breaks that I think were necessary because dht (lower case) was exported as a return type, this has been changed to DHT fix for GetSlotVsNodes so that a copy of the slots vs nodes is returned so that the caller cannot modify the returned map
* Resolving merge conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not think GetSlotVsNodes is a great but I think it should be ok for now. It can be refactored to something better.