Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quickFix: add crvUSD icon #1867

Closed
wants to merge 1 commit into from
Closed

quickFix: add crvUSD icon #1867

wants to merge 1 commit into from

Conversation

marczeller
Copy link
Collaborator

CrvUSD AIP was executed,

adding crvUSD.svg icon to allow UI to pickup.

Copy link

height bot commented Nov 27, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

github-actions bot commented Nov 27, 2023

✅ CI run has succeded!
You can find tests and deployment logs at https://github.com/aave/interface/actions/runs/7008348433'

Copy link

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 489.64 KB (🟡 +1.18 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 91.8 KB (🟡 +28 B) 581.44 KB
/404 16.26 KB (🟡 +2 B) 505.9 KB
/500 16.67 KB (🟡 +1 B) 506.32 KB
/faucet 42.57 KB (🟡 +28 B) 532.21 KB
/governance 90.26 KB (🟡 +27 B) 579.9 KB
/governance/ipfs-preview 123.81 KB (🟡 +27 B) 613.45 KB
/governance/proposal 123.97 KB (🟡 +27 B) 613.61 KB
/governance/proposal/[proposalId] 78.58 KB (🟡 +27 B) 568.22 KB
/history 50.68 KB (🟡 +27 B) 540.32 KB
/markets 37.57 KB (🟡 +3 B) 527.21 KB
/reserve-overview 40.58 KB (🟡 +29 B) 530.22 KB
/staking 36.89 KB (🟡 +26 B) 526.53 KB
/v3-migration 48.54 KB (🟡 +6 B) 538.18 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

@foodaka
Copy link
Collaborator

foodaka commented Nov 27, 2023

thanks @marczeller , closing in favor of #1868 which has a smaller sized file

@foodaka foodaka closed this Nov 27, 2023
@grothem
Copy link
Collaborator

grothem commented Nov 27, 2023

Thanks @marczeller

I'm going to close this one in favor of #1868

had an issue with the file name and added in a compressed version of the svg. Figured it was just easier to make the changes quick so we can get it live instead of going back and forth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants