Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Stream concept useful for podcast applications #841

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ppalazon
Copy link

@ppalazon ppalazon commented Mar 24, 2017

Hi, I use MPDroid with an podcast application. And I would like to add a mp3 podcast directly to MPD and play it. I reuse Stream concept, but I prefer to add to multiple playlist after added to current playlist.

I don't like to create special playlist for 'Stream' concept, and
I prefer to show up with others playlist.

If you like this change, please add to master branch.

Thanks in advance, and thanks you so much for this useful application

@ppalazon ppalazon changed the title Hi, I use MPDroid with an podcast application. And I would like to add a mp3 podcast directly to MPD and play it. I reuse Stream concept, but I prefer to add to multiple playlist after added to current playlist. Refactoring Stream concept useful for podcast applications Mar 24, 2017
@abarisain
Copy link
Owner

Hello!

As you may have noticed, MPDroid is no longer active development, meaning that I don't also take time to really review the merge requests, something essential for merging them.

I really appreciate the contributions, but I think that you should either maintain your own fork, or collaborate with other people who sent pull requests here and coordinate to make MPDroid better.

Have a nice day,

@sludgefeast
Copy link

Hi!

Please take a look at the branch develop. There are numerous improvements. In case of a refactoring your change should be done on this branch. I tried to cherry pick it, but your commits aren't really applicable to branch develop, because of many changes on affected files.

Please also take a look at my develop branch - I'm currently working on some improvements.

regards

@abarisain
Copy link
Owner

@sludgefeast Would you mind if I add a reference to your repo in the readme and contribution.md (shows up when creating PRs or issues), or would that be unwanted attention? I feel kinda bad that people are wasting time sending me PRs that I will most definitely not merge

@sludgefeast
Copy link

@abarisain Yes, please do this. Maybe we get MPDroid reanimated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants