Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getMovieInfoById - extract id from url input #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AndreiTelteu
Copy link

If you do
getMovieInfoById("http://www.imdb.com/title/tt2692904/");
it will extract the id from that url string. ("2692904")
We can do a separate function like getMovieInfoByUrl but there is no reason for that. This way is better, in my opinion.

If you do
getMovieInfoById("http://www.imdb.com/title/tt2692904/");
it will extract the id from that url string. ("2692904")
We can do a separate function like getMovieInfoByUrl but there is no reason for that. This way is better, in my opinion.
@AndreiTelteu
Copy link
Author

Actually all these works with my modification:
getMovieInfoById("http://www.imdb.com/title/tt2692904/");
getMovieInfoById("tt2692904");
getMovieInfoById("2692904");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant