Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README Enhancement - CCTV Human Detection #513

Merged
merged 7 commits into from
May 11, 2024

Conversation

aindree-2005
Copy link
Contributor

Pull Request for DL-Simplified 💡

Issue Title : #486 Update Readme for CCTV Human Detection

  • Info about the related issue (Aim of the project) :
  • Name: Aindree Chatterjee
  • GitHub ID: aindree2005
  • Email ID:
  • **Idenitfy yourself: ** GSSOC 2024

Closes: #486

Describe the add-ons or changes you've made 📃

Worked to change markdown and linked everything properly

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Markdown preview

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @aindree-2005 :)

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please put the added images inside the Images folder.
  2. Need to fix the following indentation,
    image
  3. Also can you please change the project name from CCTV-HUMAN-DETECTION to Human Detection using CCTV Footages.

Additional: Please make sure the pull request name should be same as of the issue name. I have updated the pull request title here, make sure to do the same in the future contributions.

@abhisheks008 abhisheks008 added Status: Requested Changes Changes requested. gssoc Girlscript Summer of Code 2024 labels May 11, 2024
@abhisheks008 abhisheks008 changed the title Readme README Enhancement - CCTV Human Detection May 11, 2024
@aindree-2005
Copy link
Contributor Author

@abhisheks008 fixed these in the recent commits. Please let me know if this is ok

@abhisheks008
Copy link
Owner

Remove the dot (.) from the project name.

@aindree-2005
Copy link
Contributor Author

Remove the dot (.) from the project name.

Removed it. Sorry about that.

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Your PR is approved and ready to be merged @aindree-2005.

@abhisheks008 abhisheks008 added Status: Approved Approved PR by the PA. level 1 Level 1 for GSSOC documentation Improvements or additions to documentation enhancement New feature or request and removed Status: Requested Changes Changes requested. labels May 11, 2024
@abhisheks008 abhisheks008 merged commit 8534c9b into abhisheks008:main May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request gssoc Girlscript Summer of Code 2024 level 1 Level 1 for GSSOC Points Updated Status: Approved Approved PR by the PA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README Enhancement - CCTV Human Detection
2 participants