Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[README Enhancement]: Colour Detection using DL #533

Merged
merged 2 commits into from
May 12, 2024

Conversation

jahnvisahni31
Copy link
Contributor

@jahnvisahni31 jahnvisahni31 commented May 12, 2024

Pull Request for DL-Simplified 💡

Issue Title :[README Enhancement]: Colour Detection using DL #527

Closes: #527

Describe the add-ons or changes you've made 📃

I have made the readme more eye catching with proper details and images

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested
Describe how have you verified the changes made

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @jahnvisahni31 :)

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the README template mentioned in the issue template.

@abhisheks008 abhisheks008 changed the title Update README.md [README Enhancement]: Colour Detection using DL May 12, 2024
@abhisheks008 abhisheks008 added Status: Requested Changes Changes requested. gssoc Girlscript Summer of Code 2024 labels May 12, 2024
@abhisheks008
Copy link
Owner

Hi @jahnvisahni31 also put the signature at the end of the README.

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Your PR is approved and ready to be merged.
@jahnvisahni31

@abhisheks008 abhisheks008 added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers Status: Approved Approved PR by the PA. level 1 Level 1 for GSSOC and removed Status: Requested Changes Changes requested. labels May 12, 2024
@abhisheks008 abhisheks008 merged commit 2298542 into abhisheks008:main May 12, 2024
@jahnvisahni31 jahnvisahni31 deleted the patch-1 branch May 12, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers gssoc Girlscript Summer of Code 2024 level 1 Level 1 for GSSOC Points Updated Status: Approved Approved PR by the PA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[README Enhancement]: Colour Detection using DL
2 participants