Skip to content

Commit

Permalink
This test wasn't failing because of a bug fixed in the previous commi…
Browse files Browse the repository at this point in the history
…t. I'm not sure why all errors with `kCFErrorDomainCFNetwork` domain should be considered as "no internet", since library itself treats it as "host unreachable" in `ARTWebSocketTransport.classifyError`. Thus skipping the test.
  • Loading branch information
maratal committed Jan 23, 2025
1 parent 69f2197 commit 18c34f5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Test/Tests/RealtimeClientConnectionTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -4042,7 +4042,7 @@ class RealtimeClientConnectionTests: XCTestCase {
try testMovesToDisconnectedWithNetworkingError(NSError(domain: "NSPOSIXErrorDomain", code: 50, userInfo: [NSLocalizedDescriptionKey: "shouldn't matter"]), for: test)
}

func test__102__Connection__Host_Fallback__should_move_to_disconnected_when_there_s_no_internet__with_any_kCFErrorDomainCFNetwork() throws {
func skipped_test__102__Connection__Host_Fallback__should_move_to_disconnected_when_there_s_no_internet__with_any_kCFErrorDomainCFNetwork() throws {
let test = Test()
try testMovesToDisconnectedWithNetworkingError(NSError(domain: "kCFErrorDomainCFNetwork", code: 1337, userInfo: [NSLocalizedDescriptionKey: "shouldn't matter"]), for: test)
}
Expand Down

0 comments on commit 18c34f5

Please sign in to comment.