Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.2.36 Release #2013

Merged
merged 1 commit into from
Jan 13, 2025
Merged

v1.2.36 Release #2013

merged 1 commit into from
Jan 13, 2025

Conversation

umair-ably
Copy link
Contributor

@umair-ably umair-ably commented Jan 13, 2025

Release PR for v1.2.36

Summary by CodeRabbit

  • Version Update
    • Updated library version from 1.2.35 to 1.2.36
    • Updated version references across documentation, configuration files, and test cases
    • Prepared for upcoming chat SDK features

Copy link

coderabbitai bot commented Jan 13, 2025

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 SwiftLint (0.57.0)
Test/Tests/RealtimeClientConnectionTests.swift

[
{
"character" : 42,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 107,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 44,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 109,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 86,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 125,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 60,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 127,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 46,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 139,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 59,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 183,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 51,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 857,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 51,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 898,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 51,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 930,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 51,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 971,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 51,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 1029,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 51,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 1241,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 51,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 1280,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 51,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 1671,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 51,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 1716,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 51,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 1768,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 59,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 1933,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 119,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 2011,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 52,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 2177,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 59,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 2582,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 51,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 2604,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 59,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 2615,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 51,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 2644,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 59,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 2658,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 51,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 2684,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 59,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 2698,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 53,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 2731,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 59,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 2751,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 54,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 2905,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 59,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 2953,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 59,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 3175,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 66,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 3320,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 58,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 3669,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 58,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 3700,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 24,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 3729,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 66,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 3769,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 66,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 3780,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 66,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 3811,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 44,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 4402,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 61,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 4437,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 61,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 4449,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 53,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 4459,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 51,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 4472,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 51,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 4506,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 59,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 4553,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 51,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 4570,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 59,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 4617,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 51,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 4670,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 45,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 5233,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 45,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 5313,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 45,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 5357,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 60,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 5362,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 39,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 102,
"reason" : "Force tries should be avoided",
"rule_id" : "force_try",
"severity" : "Error",
"type" : "Force Try"
},
{
"character" : 11,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 103,
"reason" : "Force tries should be avoided",
"rule_id" : "force_try",
"severity" : "Error",
"type" : "Force Try"
},
{
"character" : 27,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 3381,
"reason" : "Force tries should be avoided",
"rule_id" : "force_try",
"severity" : "Error",
"type" : "Force Try"
},
{
"character" : 27,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 3441,
"reason" : "Force tries should be avoided",
"rule_id" : "force_try",
"severity" : "Error",
"type" : "Force Try"
},
{
"character" : 31,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 3532,
"reason" : "Force tries should be avoided",
"rule_id" : "force_try",
"severity" : "Error",
"type" : "Force Try"
},
{
"character" : 36,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 5247,
"reason" : "Force tries should be avoided",
"rule_id" : "force_try",
"severity" : "Error",
"type" : "Force Try"
},
{
"character" : 57,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 5282,
"reason" : "Force tries should be avoided",
"rule_id" : "force_try",
"severity" : "Error",
"type" : "Force Try"
},
{
"character" : 36,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 5333,
"reason" : "Force tries should be avoided",
"rule_id" : "force_try",
"severity" : "Error",
"type" : "Force Try"
},
{
"character" : 57,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 5389,
"reason" : "Force tries should be avoided",
"rule_id" : "force_try",
"severity" : "Error",
"type" : "Force Try"
},
{
"character" : 73,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 2292,
"reason" : "Initializing an optional variable with nil is redundant",
"rule_id" : "redundant_optional_initialization",
"severity" : "Warning",
"type" : "Redundant Optional Initialization"
},
{
"character" : 55,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 3087,
"reason" : "Unused parameter in a closure should be replaced with _",
"rule_id" : "unused_closure_parameter",
"severity" : "Warning",
"type" : "Unused Closure Parameter"
},
{
"character" : 50,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 3346,
"reason" : "Unused parameter in a closure should be replaced with _",
"rule_id" : "unused_closure_parameter",
"severity" : "Warning",
"type" : "Unused Closure Parameter"
},
{
"character" : 50,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 3414,
"reason" : "Unused parameter in a closure should be replaced with _",
"rule_id" : "unused_closure_parameter",
"severity" : "Warning",
"type" : "Unused Closure Parameter"
},
{
"character" : 50,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 3466,
"reason" : "Unused parameter in a closure should be replaced with _",
"rule_id" : "unused_closure_parameter",
"severity" : "Warning",
"type" : "Unused Closure Parameter"
},
{
"character" : 48,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 3470,
"reason" : "Unused parameter in a closure should be replaced with _",
"rule_id" : "unused_closure_parameter",
"severity" : "Warning",
"type" : "Unused Closure Parameter"
},
{
"character" : 47,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 3474,
"reason" : "Unused parameter in a closure should be replaced with _",
"rule_id" : "unused_closure_parameter",
"severity" : "Warning",
"type" : "Unused Closure Parameter"
},
{
"character" : 50,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 3489,
"reason" : "Unused parameter in a closure should be replaced with _",
"rule_id" : "unused_closure_parameter",
"severity" : "Warning",
"type" : "Unused Closure Parameter"
},
{
"character" : 50,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 3493,
"reason" : "Unused parameter in a closure should be replaced with _",
"rule_id" : "unused_closure_parameter",
"severity" : "Warning",
"type" : "Unused Closure Parameter"
},
{
"character" : 50,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 3508,
"reason" : "Unused parameter in a closure should be replaced with _",
"rule_id" : "unused_closure_parameter",
"severity" : "Warning",
"type" : "Unused Closure Parameter"
},
{
"character" : 47,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 3512,
"reason" : "Unused parameter in a closure should be replaced with _",
"rule_id" : "unused_closure_parameter",
"severity" : "Warning",
"type" : "Unused Closure Parameter"
},
{
"character" : 50,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 3554,
"reason" : "Unused parameter in a closure should be replaced with _",
"rule_id" : "unused_closure_parameter",
"severity" : "Warning",
"type" : "Unused Closure Parameter"
},
{
"character" : 50,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 3604,
"reason" : "Unused parameter in a closure should be replaced with _",
"rule_id" : "unused_closure_parameter",
"severity" : "Warning",
"type" : "Unused Closure Parameter"
},
{
"character" : 58,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 3678,
"reason" : "Unused parameter in a closure should be replaced with _",
"rule_id" : "unused_closure_parameter",
"severity" : "Warning",
"type" : "Unused Closure Parameter"
},
{
"character" : 57,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 3709,
"reason" : "Unused parameter in a closure should be replaced with _",
"rule_id" : "unused_closure_parameter",
"severity" : "Warning",
"type" : "Unused Closure Parameter"
},
{
"character" : 60,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 3735,
"reason" : "Unused parameter in a closure should be replaced with _",
"rule_id" : "unused_closure_parameter",
"severity" : "Warning",
"type" : "Unused Closure Parameter"
},
{
"character" : 64,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 3738,
"reason" : "Unused parameter in a closure should be replaced with _",
"rule_id" : "unused_closure_parameter",
"severity" : "Warning",
"type" : "Unused Closure Parameter"
},
{
"character" : 50,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 4551,
"reason" : "Unused parameter in a closure should be replaced with _",
"rule_id" : "unused_closure_parameter",
"severity" : "Warning",
"type" : "Unused Closure Parameter"
},
{
"character" : 50,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 4615,
"reason" : "Unused parameter in a closure should be replaced with _",
"rule_id" : "unused_closure_parameter",
"severity" : "Warning",
"type" : "Unused Closure Parameter"
},
{
"character" : 50,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 4850,
"reason" : "Unused parameter in a closure should be replaced with _",
"rule_id" : "unused_closure_parameter",
"severity" : "Warning",
"type" : "Unused Closure Parameter"
},
{
"character" : 51,
"file" : "/Test/Tests/RealtimeClientConnectionTests.swift",
"line" : 4879,
"reason" : "Unused parameter in a closure should be replaced with _",
"rule_id" : "unused_closure_parameter",
"severity" : "Warning",
"type" : "Unused Closure Parameter"
}
]

Test/Tests/RestClientTests.swift

[
{
"character" : 53,
"file" : "/Test/Tests/RestClientTests.swift",
"line" : 1656,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 70,
"file" : "/Test/Tests/RestClientTests.swift",
"line" : 1658,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 48,
"file" : "/Test/Tests/RestClientTests.swift",
"line" : 1659,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
},
{
"character" : 53,
"file" : "/Test/Tests/RestClientTests.swift",
"line" : 1694,
"reason" : "Force casts should be avoided",
"rule_id" : "force_cast",
"severity" : "Error",
"type" : "Force Cast"
}
]

Walkthrough

This pull request involves a version update from 1.2.35 to 1.2.36 across multiple files in the Ably Cocoa library. The changes are consistent and comprehensive, touching documentation, configuration files, source code, and test files. The update appears to be a standard version increment that maintains the library's versioning across all relevant components, ensuring that all references to the library version are synchronized.

Changes

File Change Summary
CHANGELOG.md Added new version entry for 1.2.36
README.md Updated installation instructions to version 1.2.36
Scripts/jazzy.sh Updated module version to 1.2.36
Source/ARTClientInformation.m Updated library version constant
Test/Tests/* Updated version references in multiple test files
Version.xcconfig Updated project version to 1.2.36

Poem

🐰 A version hop, a bunny's delight,
From 1.2.35 to 36, taking flight!
Code updated, tests aligned with care,
A library refresh beyond compare.
Ably's cocoa, smooth and bright! 🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
CHANGELOG.md (1)

3-10: Format URLs as proper markdown links

The bare URLs should be formatted as markdown links for better readability and to follow markdown best practices.

-## [1.2.36](https://github.com/ably/ably-cocoa/tree/1.2.36)
+## [1.2.36][1.2.36-url]

-**Full Changelog**: https://github.com/ably/ably-cocoa/compare/1.2.35...1.2.36
+**Full Changelog**: [1.2.35...1.2.36][changelog-url]

-* Updated fields within `ARTMessage` to support upcoming chat SDK features https://github.com/ably/ably-cocoa/pull/2005
+* Updated fields within `ARTMessage` to support upcoming chat SDK features [#2005][pr-2005]

+[1.2.36-url]: https://github.com/ably/ably-cocoa/tree/1.2.36
+[changelog-url]: https://github.com/ably/ably-cocoa/compare/1.2.35...1.2.36
+[pr-2005]: https://github.com/ably/ably-cocoa/pull/2005
🧰 Tools
🪛 Markdownlint (0.37.0)

5-5: null
Bare URL used

(MD034, no-bare-urls)


9-9: null
Bare URL used

(MD034, no-bare-urls)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 23485fa and 77ce4ab.

📒 Files selected for processing (9)
  • CHANGELOG.md (1 hunks)
  • README.md (2 hunks)
  • Scripts/jazzy.sh (1 hunks)
  • Source/ARTClientInformation.m (1 hunks)
  • Test/Tests/ARTDefaultTests.swift (1 hunks)
  • Test/Tests/ClientInformationTests.swift (3 hunks)
  • Test/Tests/RealtimeClientConnectionTests.swift (1 hunks)
  • Test/Tests/RestClientTests.swift (1 hunks)
  • Version.xcconfig (1 hunks)
✅ Files skipped from review due to trivial changes (7)
  • Version.xcconfig
  • Test/Tests/ARTDefaultTests.swift
  • Scripts/jazzy.sh
  • Source/ARTClientInformation.m
  • Test/Tests/RestClientTests.swift
  • README.md
  • Test/Tests/RealtimeClientConnectionTests.swift
🧰 Additional context used
🪛 Markdownlint (0.37.0)
CHANGELOG.md

5-5: null
Bare URL used

(MD034, no-bare-urls)


9-9: null
Bare URL used

(MD034, no-bare-urls)

⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: check (macOS, test_macOS)
  • GitHub Check: check (tvOS, test_tvOS17_2)
  • GitHub Check: check
  • GitHub Check: build
  • GitHub Check: check (iOS, test_iOS17_2)
  • GitHub Check: check
🔇 Additional comments (3)
Test/Tests/ClientInformationTests.swift (3)

12-12: LGTM! Version update is consistent with the release.

The version update in the test assertion aligns with the PR objective of releasing v1.2.36.


30-30: LGTM! Version string is correctly updated.

The agent identifier test correctly reflects the new version.


45-45: LGTM! Version update is consistent.

The version string is correctly updated in the multi-agent test case.

Let's verify version consistency across the codebase:

✅ Verification successful

Version string "1.2.36" is consistently updated across the codebase

The remaining occurrences of "1.2.35" are in the changelog history and an unrelated client ID string, which is expected.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify version string consistency across the codebase
# Expect: All version strings should be updated to 1.2.36

# Search for any remaining old version strings
echo "Checking for old version strings (1.2.35):"
rg "1\.2\.35"

# Search for new version strings to ensure comprehensive updates
echo -e "\nVerifying new version strings (1.2.36):"
rg "1\.2\.36"

Length of output: 1806

@umair-ably umair-ably merged commit 5ba7809 into main Jan 13, 2025
7 of 8 checks passed
@umair-ably umair-ably deleted the release/1.2.36 branch January 13, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants