-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.2.36 Release #2013
v1.2.36 Release #2013
Conversation
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 SwiftLint (0.57.0)Test/Tests/RealtimeClientConnectionTests.swift[ Test/Tests/RestClientTests.swift[ WalkthroughThis pull request involves a version update from 1.2.35 to 1.2.36 across multiple files in the Ably Cocoa library. The changes are consistent and comprehensive, touching documentation, configuration files, source code, and test files. The update appears to be a standard version increment that maintains the library's versioning across all relevant components, ensuring that all references to the library version are synchronized. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
3-10
: Format URLs as proper markdown linksThe bare URLs should be formatted as markdown links for better readability and to follow markdown best practices.
-## [1.2.36](https://github.com/ably/ably-cocoa/tree/1.2.36) +## [1.2.36][1.2.36-url] -**Full Changelog**: https://github.com/ably/ably-cocoa/compare/1.2.35...1.2.36 +**Full Changelog**: [1.2.35...1.2.36][changelog-url] -* Updated fields within `ARTMessage` to support upcoming chat SDK features https://github.com/ably/ably-cocoa/pull/2005 +* Updated fields within `ARTMessage` to support upcoming chat SDK features [#2005][pr-2005] +[1.2.36-url]: https://github.com/ably/ably-cocoa/tree/1.2.36 +[changelog-url]: https://github.com/ably/ably-cocoa/compare/1.2.35...1.2.36 +[pr-2005]: https://github.com/ably/ably-cocoa/pull/2005🧰 Tools
🪛 Markdownlint (0.37.0)
5-5: null
Bare URL used(MD034, no-bare-urls)
9-9: null
Bare URL used(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
CHANGELOG.md
(1 hunks)README.md
(2 hunks)Scripts/jazzy.sh
(1 hunks)Source/ARTClientInformation.m
(1 hunks)Test/Tests/ARTDefaultTests.swift
(1 hunks)Test/Tests/ClientInformationTests.swift
(3 hunks)Test/Tests/RealtimeClientConnectionTests.swift
(1 hunks)Test/Tests/RestClientTests.swift
(1 hunks)Version.xcconfig
(1 hunks)
✅ Files skipped from review due to trivial changes (7)
- Version.xcconfig
- Test/Tests/ARTDefaultTests.swift
- Scripts/jazzy.sh
- Source/ARTClientInformation.m
- Test/Tests/RestClientTests.swift
- README.md
- Test/Tests/RealtimeClientConnectionTests.swift
🧰 Additional context used
🪛 Markdownlint (0.37.0)
CHANGELOG.md
5-5: null
Bare URL used
(MD034, no-bare-urls)
9-9: null
Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: check (macOS, test_macOS)
- GitHub Check: check (tvOS, test_tvOS17_2)
- GitHub Check: check
- GitHub Check: build
- GitHub Check: check (iOS, test_iOS17_2)
- GitHub Check: check
🔇 Additional comments (3)
Test/Tests/ClientInformationTests.swift (3)
12-12
: LGTM! Version update is consistent with the release.The version update in the test assertion aligns with the PR objective of releasing v1.2.36.
30-30
: LGTM! Version string is correctly updated.The agent identifier test correctly reflects the new version.
45-45
: LGTM! Version update is consistent.The version string is correctly updated in the multi-agent test case.
Let's verify version consistency across the codebase:
✅ Verification successful
Version string "1.2.36" is consistently updated across the codebase
The remaining occurrences of "1.2.35" are in the changelog history and an unrelated client ID string, which is expected.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify version string consistency across the codebase # Expect: All version strings should be updated to 1.2.36 # Search for any remaining old version strings echo "Checking for old version strings (1.2.35):" rg "1\.2\.35" # Search for new version strings to ensure comprehensive updates echo -e "\nVerifying new version strings (1.2.36):" rg "1\.2\.36"Length of output: 1806
Release PR for v1.2.36
Summary by CodeRabbit