Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush bad request and disconnect responses #201

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

diyan
Copy link

@diyan diyan commented Sep 8, 2014

Without flushing we will have empty response.

For example Nginx will return HTTP 502 Bad Gateway instead of correct response in such cases.

@diyan
Copy link
Author

diyan commented Sep 8, 2014

Also I did a bugfix for JSONPolling transport.

Please let me know if you would like me create separate pull request.

Commits with "JSONPolling" prefix fixes a following warning that appears in browsers:

Resource interpreted as Script but transferred with MIME type text/plain: "https://example.com/socket.io/1/jsonp-polling/580139618792?t=1410183159408&i=0".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant