Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hiking profile #424

Merged
merged 2 commits into from
Apr 24, 2022
Merged

Conversation

zod
Copy link
Collaborator

@zod zod commented Apr 24, 2022

The hiking profile is quite outdated. Android users can manually get there preferred version from https://github.com/poutnikl/Brouter-profiles but it would be nice for users of brouter-web if they can use the current profile without manually uploading it.

I've used the SAC3 version because it seemed that hiking-beta was an older version of the SAC3 profile. To inform users that they should expect some smaller paths I've named it hiking-mountain but removed the SAC information as it might be confusing.

@poutnikl I didn't find any license information on your repository, but I guess since the profile was already used in the past you are also ok with an updated version.

@nrenner I've just had a look how brouter-web uses the profiles and noticed that renaming the profile would require updating brouter-web and all translations to remove the beta term. Should we keep the old filename?

@zod zod added the profiles label Apr 24, 2022
@poutnikl
Copy link
Contributor

poutnikl commented Apr 24, 2022

The hiking-beta profile was an early beta version of what later become the profile template for all my hiking profiles that are just the generated parametrized template from the respective GitHub hiking template project.

I am not great at licencing management, but I grant here permission to use it for Brouter/Brouter-web while it remains free product, until further notice.

@afischerdev afischerdev merged commit 7a6f54e into abrensch:master Apr 24, 2022
@nrenner
Copy link
Contributor

nrenner commented May 20, 2022

renaming the profile would require updating brouter-web and all translations to remove the beta term. Should we keep the old filename?

I don't mind the rename and would want to remove the (beta) in any case.

@zod zod deleted the update-hiking-profile branch May 21, 2022 04:33
@zod
Copy link
Collaborator Author

zod commented May 28, 2022

@abrensch or @nrenner
I'm not sure who has access to https://brouter.de/brouter/profiles2/ but it would be great to provide hiking-mountain.brf because the update mechanism of the android app fails otherwise since #426 was merged.

@afischerdev
Copy link
Collaborator

And I would add, may be there is a general way for publishing. eg. may be #416 comes to an end and would like see the world.

@nrenner
Copy link
Contributor

nrenner commented May 31, 2022

@zod Done.

Just curious, do you need this for own installation from master?

the update mechanism of the android app fails otherwise

Shouldn't that be made more stable then?

@zod
Copy link
Collaborator Author

zod commented Jun 2, 2022

@zod Done.

Thanks!

Just curious, do you need this for own installation from master?

It's not for the installation, but when downloading segments the lookup & profiles are also updated. The current master uses the new profile which hasn't been available for download.

the update mechanism of the android app fails otherwise

Shouldn't that be made more stable then?

We could just report the error but continue downloading the segments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants