-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve town, forest and river tags #614
base: master
Are you sure you want to change the base?
Conversation
- Increase the size threshold for ponds to 10000 - Decrease the lower population threshold to 1000 - Subtract meadow and farmland from the town area - Only subtract ways which are truely inside of a green area - Limit the `estimated_forest_tag` to forests and only forests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't test the fine tuning at the moment. May be @EssBee59 could test more.
But I see the st_area is fixed. And it's running error free against the database.
This draft is not about fine-tuning. It is about fixing some of the most frustrating flaws in the current logic, and beyond that, untangling the city, forest, and river tags to give profile creators the freedom to nest them together as needed. The current situation in three pictures:
|
@EssBee59, this PR fixes the problem shown in Example 1 by subtracting meadow and farmland landuse polygons from the town polygon, the one shown in Example 2 by greatly decreasing the lower population limit (I would prefer 1k as lower limit) and the one shown in Example 3 by only subtracting ways which are inside of green areas (this might need some more fine-tuning). The performance overhead is definitely manageable and should not be the reason to not fix these problems. If you have other ideas on how to fix them, please let me know. |
Intended as a basis for discussion on the further development of the pseudo tags:
estimated_forest_tag
to forests and only forestsExample: https://brouter.de/brouter-web/#map=12/50.1407/8.7074/...profile=fastbike (with
consider_town
enabled)