Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start way check added #728

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Start way check added #728

merged 1 commit into from
Sep 12, 2024

Conversation

afischerdev
Copy link
Collaborator

This is the answer on the issues #600 and #682.

The idea is to place a definition for excludes highways in the profile.
This is scanned at routing start and an array is created with the index of the lookup entry and the lookup value.
The array is then used to exclude the way from the routing.

The test server is prepared for using this feature.
You have to assign a new global rule in the profile - there is no entry for this feature in the profiles at the moment.

assign   check_start_way          = true   # %check_start_way% | Activate a test for the starting way | boolean | noStartWay=route,ferry;highway,motorway;highway,motorway_link

As you see the comment part of the assign has in this case an array with 4 entries - please note, the web client can not check that at the moment, so you don't see the assigned entry in the option window (I guess, some of the RegEx in Profile.js should be changed).
The fourth part of the array contains the excluded entries.

noStartWay= - a fix constant for this new feature
route,ferry - entry for route=ferry
; - more entries comes here

Here the links for the test server:
issue 600
issee 682

@afischerdev afischerdev added this to the 1.7.8 milestone Sep 12, 2024
@afischerdev afischerdev merged commit 1e6c409 into abrensch:master Sep 12, 2024
2 checks passed
@rtwalz
Copy link

rtwalz commented Oct 23, 2024

Just want to say this feature helped me for a project, I really appreciate it :)

@afischerdev
Copy link
Collaborator Author

@rtwalz
Thank you for the info. It is alway good to know that someone is using it - and it is working as intended.

@rtwalz
Copy link

rtwalz commented Oct 25, 2024

I would love a similar way to specify which ways to exclude for the destination, perhaps a check_end_way rule.

My use case is for walking directions. Many urban areas have poorly connected sidewalks, so I would prefer to not start or end at them, but I still want to consider sidewalks for the route. For example, this sidewalk is not connected to every intersection, so Brouter's route goes all the way around and is longer than necessary.

Screenshot 2024-10-25 at 10 44 39 AM

@afischerdev
Copy link
Collaborator Author

@rtwalz
I understand your intention, but don't you think it is better do connect the sideways to junctions? It is hard to say if this sideway is behind a wall or not.

@afischerdev afischerdev deleted the startway branch October 27, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants