Merge pull request #1288 from imahmedismail/imahmedismail/few-readabi…

…lity-fixes

[ready-for-review] Remove some code-readability issues like:

lib/absinthe/middleware/async.ex

@@ -113,10 +113,10 @@ defmodule Absinthe.Middleware.Async do
 
   # Optionally use `async/1` function from `opentelemetry_process_propagator` if available
   if Code.ensure_loaded?(OpentelemetryProcessPropagator.Task) do
-    @spec async((-> any)) :: Task.t()
+    @spec async((() -> any)) :: Task.t()
     defdelegate async(fun), to: OpentelemetryProcessPropagator.Task
   else
-    @spec async((-> any)) :: Task.t()
+    @spec async((() -> any)) :: Task.t()
     defdelegate async(fun), to: Task
   end
 end

lib/absinthe/middleware/batch.ex

@@ -209,10 +209,10 @@ defmodule Absinthe.Middleware.Batch do
 
   # Optionally use `async/1` function from `opentelemetry_process_propagator` if available
   if Code.ensure_loaded?(OpentelemetryProcessPropagator.Task) do
-    @spec async((-> any)) :: Task.t()
+    @spec async((() -> any)) :: Task.t()
     defdelegate async(fun), to: OpentelemetryProcessPropagator.Task
   else
-    @spec async((-> any)) :: Task.t()
+    @spec async((() -> any)) :: Task.t()
     defdelegate async(fun), to: Task
   end
 end

lib/absinthe/phase/schema/validation/interfaces_must_resolve_types.ex

@@ -31,7 +31,7 @@ defmodule Absinthe.Phase.Schema.Validation.InterfacesMustResolveTypes do
   defp validate_interface(%Blueprint.Schema.InterfaceTypeDefinition{} = iface, implementors) do
     resolve_type = Absinthe.Type.function(iface, :resolve_type)
 
-    if(resolve_type || all_objects_is_type_of?(iface, implementors)) do
+    if resolve_type || all_objects_is_type_of?(iface, implementors) do
       iface
     else
       iface |> put_error(error(iface))

lib/absinthe/resolution/helpers.ex

@@ -34,8 +34,8 @@ defmodule Absinthe.Resolution.Helpers do
   end
   ```
   """
-  @spec async((-> term)) :: {:middleware, Middleware.Async, term}
-  @spec async((-> term), opts :: [{:timeout, pos_integer}]) ::
+  @spec async((() -> term)) :: {:middleware, Middleware.Async, term}
+  @spec async((() -> term), opts :: [{:timeout, pos_integer}]) ::
           {:middleware, Middleware.Async, term}
   def async(fun, opts \\ []) do
     {:middleware, Middleware.Async, {fun, opts}}

test/absinthe/integration/execution/input_types/null/literal_to_element_of_type_list_of_T_test.exs

@@ -1,4 +1,4 @@
-defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.LiteralToElementOfTypeListOf_TTest do
+defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.LiteralToElementOfTypeListOfTTest do
   use Absinthe.Case, async: true
 
   @query """

test/absinthe/integration/execution/input_types/null/literal_to_element_of_type_non_null_list_of_T_test.exs

@@ -1,4 +1,4 @@
-defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.LiteralToElementOfTypeNonNullListOf_TTest do
+defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.LiteralToElementOfTypeNonNullListOfTTest do
   use Absinthe.Case, async: true
 
   @query """

test/absinthe/integration/execution/input_types/null/literal_to_type_T_overrides_default_value_test.exs

@@ -1,4 +1,4 @@
-defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.LiteralToType_TOverridesDefaultValueTest do
+defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.LiteralToTypeTOverridesDefaultValueTest do
   use Absinthe.Case, async: true
 
   @query """

test/absinthe/integration/execution/input_types/null/literal_to_type_list_of_T_test.exs

@@ -1,4 +1,4 @@
-defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.LiteralToTypeListOf_TTest do
+defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.LiteralToTypeListOfTTest do
   use Absinthe.Case, async: true
 
   @query """

test/absinthe/integration/execution/input_types/null/literal_to_type_non_null_T_test.exs

@@ -1,4 +1,4 @@
-defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.LiteralToTypeNonNull_TTest do
+defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.LiteralToTypeNonNullTTest do
   use Absinthe.Case, async: true
 
   @query """

test/absinthe/integration/execution/input_types/null/literal_to_type_non_null_list_of_T_element_test.exs

@@ -1,4 +1,4 @@
-defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.LiteralToTypeNonNullListOf_TElementTest do
+defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.LiteralToTypeNonNullListOfTElementTest do
   use Absinthe.Case, async: true
 
   @query """

test/absinthe/integration/execution/input_types/null/literal_to_type_non_null_list_of_T_test.exs

@@ -1,4 +1,4 @@
-defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.LiteralToTypeNonNullListOf_TTest do
+defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.LiteralToTypeNonNullListOfTTest do
   use Absinthe.Case, async: true
 
   @query """

test/absinthe/integration/execution/input_types/null/literal_to_type_non_null_list_of_non_null_T_element_test.exs

@@ -1,4 +1,4 @@
-defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.LiteralToTypeNonNullListOfNonNull_TElementTest do
+defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.LiteralToTypeNonNullListOfNonNullTElementTest do
   use Absinthe.Case, async: true
 
   @query """

test/absinthe/integration/execution/input_types/null/literal_to_type_non_null_list_of_non_null_T_test.exs

@@ -1,4 +1,4 @@
-defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.LiteralToTypeNonNullListOfNonNull_TTest do
+defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.LiteralToTypeNonNullListOfNonNullTTest do
   use Absinthe.Case, async: true
 
   @query """

test/absinthe/integration/execution/input_types/null/variable_to_type_T_overrides_default_value_test.exs

@@ -1,4 +1,4 @@
-defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.VariableToType_TOverridesDefaultValueTest do
+defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.VariableToTypeTOverridesDefaultValueTest do
   use Absinthe.Case, async: true
 
   @query """

test/absinthe/integration/execution/input_types/null/variable_to_type_T_test.exs

@@ -1,4 +1,4 @@
-defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.VariableToType_TTest do
+defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.VariableToTypeTTest do
   use Absinthe.Case, async: true
 
   @query """

test/absinthe/integration/execution/input_types/null/variable_to_type_list_of_T_element_test.exs

@@ -1,4 +1,4 @@
-defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.VariableToTypeListOf_TElementTest do
+defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.VariableToTypeListOfTElementTest do
   use Absinthe.Case, async: true
 
   @query """

test/absinthe/integration/execution/input_types/null/variable_to_type_list_of_T_test.exs

@@ -1,4 +1,4 @@
-defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.VariableToTypeListOf_TTest do
+defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.VariableToTypeListOfTTest do
   use Absinthe.Case, async: true
 
   @query """

test/absinthe/integration/execution/input_types/null/variable_to_type_non_null_T_test.exs

@@ -1,4 +1,4 @@
-defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.VariableToTypeNonNull_TTest do
+defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.VariableToTypeNonNullTTest do
   use Absinthe.Case, async: true
 
   @query """

test/absinthe/integration/execution/input_types/null/variable_to_type_non_null_list_of_T_element_test.exs

@@ -1,4 +1,4 @@
-defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.VariableToTypeNonNullListOf_TElementTest do
+defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.VariableToTypeNonNullListOfTElementTest do
   use Absinthe.Case, async: true
 
   @query """

test/absinthe/integration/execution/input_types/null/variable_to_type_non_null_list_of_T_test.exs

@@ -1,4 +1,4 @@
-defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.VariableToTypeNonNullListOf_TTest do
+defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.VariableToTypeNonNullListOfTTest do
   use Absinthe.Case, async: true
 
   @query """

test/absinthe/integration/execution/input_types/null/variable_to_type_non_null_list_of_non_null_T_element_test.exs

@@ -1,4 +1,4 @@
-defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.VariableToTypeNonNullListOfNonNull_TElementTest do
+defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.VariableToTypeNonNullListOfNonNullTElementTest do
   use Absinthe.Case, async: true
 
   @query """

test/absinthe/integration/execution/input_types/null/variable_to_type_non_null_list_of_non_null_T_test.exs

@@ -1,4 +1,4 @@
-defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.VariableToTypeNonNullListOfNonNull_TTest do
+defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.VariableToTypeNonNullListOfNonNullTTest do
   use Absinthe.Case, async: true
 
   @query """

test/absinthe/integration/execution/input_types/null/variable_to_variable_type_non_null_T_test.exs

@@ -1,4 +1,4 @@
-defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.VariableToVariableTypeNonNull_TTest do
+defmodule Elixir.Absinthe.Integration.Execution.InputTypes.Null.VariableToVariableTypeNonNullTTest do
   use Absinthe.Case, async: true
 
   @query """

test/absinthe/integration/execution/operation_by_name_test.exs

@@ -55,9 +55,7 @@ defmodule Elixir.Absinthe.Integration.Execution.OperationByNameTest do
 
   test "scenario #4" do
     assert {:ok, %{data: %{"thing" => %{"name" => "Bar"}}}} ==
-             Absinthe.run(@query, Absinthe.Fixtures.Things.MacroSchema,
-               operation_name: "ThingBar"
-             )
+             Absinthe.run(@query, Absinthe.Fixtures.Things.MacroSchema, operation_name: "ThingBar")
   end
 
   @query """

test/absinthe/lexer_test.exs

@@ -116,7 +116,7 @@ defmodule Absinthe.LexerTest do
   end
 
   defp too_long_query do
-    Enum.to_list(for n <- 1..10000, do: "test#{n}")
+    Enum.to_list(for n <- 1..10_000, do: "test#{n}")
     |> deep_query()
   end
 

test/absinthe/pipeline_test.exs

@@ -41,23 +41,23 @@ defmodule Absinthe.PipelineTest do
       end
     end
 
-    @goodQuery """
+    @good_query """
     { foo { bar } }
     """
 
-    @badQuery """
+    @bad_query """
     { noFoo { bar } }
     """
     test "well-formed query" do
       {:ok, %{execution: %{validation_errors: validation_errors}}, _} =
-        validation_only_query(@goodQuery)
+        validation_only_query(@good_query)
 
       assert length(validation_errors) == 0
     end
 
     test "ill-formed query" do
       {:ok, %{execution: %{validation_errors: validation_errors}}, _} =
-        validation_only_query(@badQuery)
+        validation_only_query(@bad_query)
 
       refute length(validation_errors) == 0
     end

test/absinthe/subscription/pipeline_serializer_test.exs

@@ -58,8 +58,7 @@ defmodule Absinthe.Subscription.PipelineSerializerTest do
                 0 => %{large: 123},
                 1 => [context: [:pack | 0]],
                 2 => [context: [:pack | 0], another: 456]
-              }} =
-               PipelineSerializer.pack(pipeline)
+              }} = PipelineSerializer.pack(pipeline)
     end
   end