Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store less information in the registry #1261

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Store less information in the registry #1261

merged 2 commits into from
Aug 11, 2023

Conversation

josevalim
Copy link
Contributor

Instead of storing data in the registry keyed by self(),
we put that in the process dictionary. Although the process
dictionary is discouraged, they are equivalent here:
they are both a form of side-effect although pdict is
considerably less expensive.

josevalim and others added 2 commits August 11, 2023 12:07
Instead of storing data in the registry keyed by self(),
we put that in the process dictionary. Although the
process dictionary is discouraged, they are equivalent
here: they are both a form of side-effect although
pdict is considerably less expensive.
Copy link
Contributor

@benwilson512 benwilson512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes tons of sense, don't know why I didn't think of this originally! Thanks!

lib/absinthe/subscription.ex Outdated Show resolved Hide resolved
@benwilson512 benwilson512 merged commit f756bb3 into absinthe-graphql:master Aug 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants