Update Apollo Client documentation to use Apollo Client v3 imports #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerelmiller
commented
Nov 11, 2023
| import * as AbsintheSocket from "@absinthe/socket"; | ||
| import { createAbsintheSocketLink } from "@absinthe/socket-apollo-link"; | ||
| import { Socket as PhoenixSocket } from "phoenix"; | ||
| import { hasSubscription } from "@jumpn/utils-graphql"; |
There was a problem hiding this comment.
To avoid an additional dependency in the user's codebase, I've gone ahead and updated this example to use our recommendation in the directional composition section of our docs.
benwilson512
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
I am a maintainer on Apollo Client and happened to notice that the Apollo Client documentation is using the outdated v2 imports. I've updated the documentation to use the v3 imports in this PR in an effort to try and keep it consistent with the latest versions of Apollo Client. Hope this helps! Thanks for such a great library!