Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type resolution by recursing prototypes #1334

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Fix type resolution by recursing prototypes #1334

merged 2 commits into from
Aug 20, 2024

Commits on Aug 20, 2024

  1. Fix type resolution by recursing prototypes 

    This fixes an issue when you have types declared in a Prototype (such as
input_object input types for a directive). Previously type resolution
would look on the Schema, but not the Prototype for the type
definitions.

You _could_ workaround this by duplicating your type definition into
both the Schema and the Prototype. This makes me somewhat curious if
there is a better way to fix this, in that the code that was trying to
resolve the type here shouldn't be resolving it on the Schema, but
rather on the Prototype 🤷. This seems to work though.

Fixes absinthe-graphql#1279
    @jeffutter
    jeffutter committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    03a16e4 View commit details
    Browse the repository at this point in the history

  2. Merge types and referenced_types from custom schema prototypes

    @jeffutter
    jeffutter committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    fad950d View commit details
    Browse the repository at this point in the history