Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Add Readers and Consumers SDK #33

Merged
merged 11 commits into from
Jan 13, 2025

refactor: remove notifier interface

ebe52aa
Select commit
Loading
Failed to load commit list.
Merged

NOISSUE - Add Readers and Consumers SDK #33

refactor: remove notifier interface
ebe52aa
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 13, 2025 in 0s

55.62% (+31.68%) compared to ec71a5e

View this Pull Request on Codecov

55.62% (+31.68%) compared to ec71a5e

Details

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 55.62%. Comparing base (ec71a5e) to head (ebe52aa).

Files with missing lines Patch % Lines
consumers/notifiers/service.go 33.33% 2 Missing ⚠️
consumers/notifiers/smpp/notifier.go 0.00% 1 Missing ⚠️
consumers/notifiers/smtp/notifier.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main      #33       +/-   ##
===========================================
+ Coverage   23.93%   55.62%   +31.68%     
===========================================
  Files          79       60       -19     
  Lines       12433     5316     -7117     
===========================================
- Hits         2976     2957       -19     
+ Misses       9116     2031     -7085     
+ Partials      341      328       -13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov