NOISSUE - Fix readers #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ianmuchyri <[email protected]>
Signed-off-by: ianmuchyri <[email protected]>
Signed-off-by: ianmuchyri <[email protected]>
ianmuchyri
force-pushed
the
noissue-fixreader
branch
from
6f7b8ef to
b1d5a88
Compare
Signed-off-by: ianmuchyri <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
===========================================
+ Coverage 28.75% 59.61% +30.85%
===========================================
Files 89 33 -56
Lines 13537 1899 -11638
===========================================
- Hits 3893 1132 -2761
+ Misses 9178 670 -8508
+ Partials 466 97 -369 ☔ View full report in Codecov by Sentry. |
dborovcanin
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a refactor pr.
What does this do?
It updates the readers to include the domain id in authorization for users. Also updates the environment variables for the various services.
Which issue(s) does this PR fix/relate to?
Noissue
Have you included tests for your changes?
No
Did you document any new/modified feature?
No
Notes