Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Fix message reader sdk url #52

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

ianmuchyri
Copy link
Contributor

What type of PR is this?

This is a bug fix

What does this do?

Update the url of the message reader sdk to include domain id. This will sync with the change in the service

Which issue(s) does this PR fix/relate to?

noissue

  • Related Issue #
  • Resolves #

Have you included tests for your changes?

no

Did you document any new/modified feature?

no

Notes

Signed-off-by: ianmuchyri <[email protected]>
@ianmuchyri ianmuchyri force-pushed the noissue-fixreadersdk branch from efdba0a to 8729f9d Compare January 24, 2025 12:25
@ianmuchyri ianmuchyri marked this pull request as ready for review January 24, 2025 12:26
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.41%. Comparing base (6e1efa5) to head (8729f9d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #52       +/-   ##
===========================================
+ Coverage   28.75%   49.41%   +20.65%     
===========================================
  Files          89       33       -56     
  Lines       13537     4122     -9415     
===========================================
- Hits         3893     2037     -1856     
+ Misses       9178     1850     -7328     
+ Partials      466      235      -231     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dborovcanin dborovcanin merged commit b853f9e into absmach:main Jan 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants