NOISSUE - Add property based testing to things service #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodneyosodo
force-pushed
the
things-schemathesis
branch
4 times, most recently
from
6d083a7 to
b769e32
Compare
rodneyosodo
force-pushed
the
things-schemathesis
branch
3 times, most recently
from
5355efc to
de840b6
Compare
rodneyosodo
force-pushed
the
things-schemathesis
branch
3 times, most recently
from
3307677 to
8888de7
Compare
rodneyosodo
force-pushed
the
things-schemathesis
branch
2 times, most recently
from
56dbebf to
3f56a84
Compare
rodneyosodo
force-pushed
the
things-schemathesis
branch
8 times, most recently
from
95cb54d to
7127cfc
Compare
dborovcanin
requested changes
Apr 8, 2024
Signed-off-by: Rodney Osodo <[email protected]>
- Update API endpoints, error codes, schemas, and validation patterns - Improve descriptions and documentation for various components - Add operation IDs and links for operations Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]> Signed-off-by: rodneyosodo <[email protected]> Signed-off-by: Rodney Osodo <[email protected]>
This is because of the uncertainity of schemathesis Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
rodneyosodo
force-pushed
the
things-schemathesis
branch
from
7127cfc to
5becb91
Compare
dborovcanin
approved these changes
Apr 9, 2024
JeffMboya
pushed a commit
to JeffMboya/supermq
that referenced
this pull request
Apr 10, 2024
Signed-off-by: Rodney Osodo <[email protected]> Signed-off-by: rodneyosodo <[email protected]>
JeffMboya
pushed a commit
to JeffMboya/supermq
that referenced
this pull request
Apr 11, 2024
Signed-off-by: Rodney Osodo <[email protected]> Signed-off-by: rodneyosodo <[email protected]> Signed-off-by: JeffMboya <[email protected]>
JeffMboya
pushed a commit
to JeffMboya/supermq
that referenced
this pull request
Apr 11, 2024
Signed-off-by: Rodney Osodo <[email protected]> Signed-off-by: rodneyosodo <[email protected]>
JeffMboya
pushed a commit
to JeffMboya/supermq
that referenced
this pull request
Apr 11, 2024
Signed-off-by: Rodney Osodo <[email protected]> Signed-off-by: rodneyosodo <[email protected]>
JeffMboya
pushed a commit
to JeffMboya/supermq
that referenced
this pull request
Apr 11, 2024
Signed-off-by: Rodney Osodo <[email protected]> Signed-off-by: rodneyosodo <[email protected]> Signed-off-by: JeffMboya <[email protected]>
JeffMboya
pushed a commit
to JeffMboya/supermq
that referenced
this pull request
Apr 13, 2024
Signed-off-by: Rodney Osodo <[email protected]> Signed-off-by: rodneyosodo <[email protected]> Signed-off-by: JeffMboya <[email protected]>
JeffMboya
added a commit
to JeffMboya/supermq
that referenced
this pull request
Apr 13, 2024
Signed-off-by: JeffMboya <[email protected]> Refactor mqtt handler tests to include eventStore in newHandler function Signed-off-by: JeffMboya <[email protected]> NOISSUE - Add property based testing to things service (absmach#2088) Signed-off-by: Rodney Osodo <[email protected]> Signed-off-by: rodneyosodo <[email protected]> Signed-off-by: JeffMboya <[email protected]> Fix URLs in api-tests.yml Signed-off-by: JeffMboya <[email protected]>
JeffMboya
added a commit
to JeffMboya/supermq
that referenced
this pull request
Apr 13, 2024
Signed-off-by: JeffMboya <[email protected]> Refactor mqtt handler tests to include eventStore in newHandler function Signed-off-by: JeffMboya <[email protected]> NOISSUE - Add property based testing to things service (absmach#2088) Signed-off-by: Rodney Osodo <[email protected]> Signed-off-by: rodneyosodo <[email protected]> Signed-off-by: JeffMboya <[email protected]> Fix URLs in api-tests.yml Signed-off-by: JeffMboya <[email protected]> Add MQTT EventStore mock directive to check-generated-files.yml Signed-off-by: JeffMboya <[email protected]> Refactor mqtt handler tests to use svcCall instead of repoCall in handler_test.go Signed-off-by: JeffMboya <[email protected]> Replace mock.Anything in TestAuthConnect Signed-off-by: JeffMboya <[email protected]> Replace mock.Anything in TestDisconnect Signed-off-by: JeffMboya <[email protected]> Replace nil with tc.err in return values Signed-off-by: JeffMboya <[email protected]> Replace nil with tc.err in return values Signed-off-by: JeffMboya <[email protected]> NOISSUE - Update the location of MQTT API docs (absmach#2172) Signed-off-by: Emmanuel Ferdman <[email protected]> Replace context.Anything with respective context Signed-off-by: JeffMboya <[email protected]>
JeffMboya
added a commit
to JeffMboya/supermq
that referenced
this pull request
Apr 13, 2024
Signed-off-by: JeffMboya <[email protected]> Refactor mqtt handler tests to include eventStore in newHandler function Signed-off-by: JeffMboya <[email protected]> NOISSUE - Add property based testing to things service (absmach#2088) Signed-off-by: Rodney Osodo <[email protected]> Signed-off-by: rodneyosodo <[email protected]> Signed-off-by: JeffMboya <[email protected]> Fix URLs in api-tests.yml Signed-off-by: JeffMboya <[email protected]> Add MQTT EventStore mock directive to check-generated-files.yml Signed-off-by: JeffMboya <[email protected]> Refactor mqtt handler tests to use svcCall instead of repoCall in handler_test.go Signed-off-by: JeffMboya <[email protected]> Replace mock.Anything in TestAuthConnect Signed-off-by: JeffMboya <[email protected]> Replace mock.Anything in TestDisconnect Signed-off-by: JeffMboya <[email protected]> Replace nil with tc.err in return values Signed-off-by: JeffMboya <[email protected]> Replace nil with tc.err in return values Signed-off-by: JeffMboya <[email protected]> NOISSUE - Update the location of MQTT API docs (absmach#2172) Signed-off-by: Emmanuel Ferdman <[email protected]> Replace context.Anything with respective context Signed-off-by: JeffMboya <[email protected]>
JeffMboya
added a commit
to JeffMboya/supermq
that referenced
this pull request
Apr 15, 2024
Signed-off-by: JeffMboya <[email protected]> Refactor mqtt handler tests to include eventStore in newHandler function Signed-off-by: JeffMboya <[email protected]> NOISSUE - Add property based testing to things service (absmach#2088) Signed-off-by: Rodney Osodo <[email protected]> Signed-off-by: rodneyosodo <[email protected]> Signed-off-by: JeffMboya <[email protected]> Fix URLs in api-tests.yml Signed-off-by: JeffMboya <[email protected]> Add MQTT EventStore mock directive to check-generated-files.yml Signed-off-by: JeffMboya <[email protected]> Refactor mqtt handler tests to use svcCall instead of repoCall in handler_test.go Signed-off-by: JeffMboya <[email protected]> Replace mock.Anything in TestAuthConnect Signed-off-by: JeffMboya <[email protected]> Replace mock.Anything in TestDisconnect Signed-off-by: JeffMboya <[email protected]> Replace nil with tc.err in return values Signed-off-by: JeffMboya <[email protected]> Replace nil with tc.err in return values Signed-off-by: JeffMboya <[email protected]> NOISSUE - Update the location of MQTT API docs (absmach#2172) Signed-off-by: Emmanuel Ferdman <[email protected]> Replace context.Anything with respective context Signed-off-by: JeffMboya <[email protected]>
JeffMboya
added a commit
to JeffMboya/supermq
that referenced
this pull request
Apr 15, 2024
Signed-off-by: JeffMboya <[email protected]> Refactor mqtt handler tests to include eventStore in newHandler function Signed-off-by: JeffMboya <[email protected]> NOISSUE - Add property based testing to things service (absmach#2088) Signed-off-by: Rodney Osodo <[email protected]> Signed-off-by: rodneyosodo <[email protected]> Signed-off-by: JeffMboya <[email protected]> Fix URLs in api-tests.yml Signed-off-by: JeffMboya <[email protected]> Add MQTT EventStore mock directive to check-generated-files.yml Signed-off-by: JeffMboya <[email protected]> Refactor mqtt handler tests to use svcCall instead of repoCall in handler_test.go Signed-off-by: JeffMboya <[email protected]> Replace mock.Anything in TestAuthConnect Signed-off-by: JeffMboya <[email protected]> Replace mock.Anything in TestDisconnect Signed-off-by: JeffMboya <[email protected]> Replace nil with tc.err in return values Signed-off-by: JeffMboya <[email protected]> Replace nil with tc.err in return values Signed-off-by: JeffMboya <[email protected]> NOISSUE - Update the location of MQTT API docs (absmach#2172) Signed-off-by: Emmanuel Ferdman <[email protected]> Replace context.Anything with respective context Signed-off-by: JeffMboya <[email protected]> Generate mocks with mockery for mqtt Signed-off-by: JeffMboya <[email protected]> Generate mocks with mockery for mqtt Signed-off-by: JeffMboya <[email protected]>
JeffMboya
added a commit
to JeffMboya/supermq
that referenced
this pull request
Apr 15, 2024
Signed-off-by: JeffMboya <[email protected]> Refactor mqtt handler tests to include eventStore in newHandler function Signed-off-by: JeffMboya <[email protected]> NOISSUE - Add property based testing to things service (absmach#2088) Signed-off-by: Rodney Osodo <[email protected]> Signed-off-by: rodneyosodo <[email protected]> Signed-off-by: JeffMboya <[email protected]> Fix URLs in api-tests.yml Signed-off-by: JeffMboya <[email protected]> Add MQTT EventStore mock directive to check-generated-files.yml Signed-off-by: JeffMboya <[email protected]> Refactor mqtt handler tests to use svcCall instead of repoCall in handler_test.go Signed-off-by: JeffMboya <[email protected]> Replace mock.Anything in TestAuthConnect Signed-off-by: JeffMboya <[email protected]> Replace mock.Anything in TestDisconnect Signed-off-by: JeffMboya <[email protected]> Replace nil with tc.err in return values Signed-off-by: JeffMboya <[email protected]> Replace nil with tc.err in return values Signed-off-by: JeffMboya <[email protected]> NOISSUE - Update the location of MQTT API docs (absmach#2172) Signed-off-by: Emmanuel Ferdman <[email protected]> Replace context.Anything with respective context Signed-off-by: JeffMboya <[email protected]> Generate mocks with mockery for mqtt Signed-off-by: JeffMboya <[email protected]> Generate mocks with mockery for mqtt Signed-off-by: JeffMboya <[email protected]> Generate mocks with mockery for mqtt Signed-off-by: JeffMboya <[email protected]>
dborovcanin
pushed a commit
to JeffMboya/supermq
that referenced
this pull request
Apr 15, 2024
Signed-off-by: JeffMboya <[email protected]> Refactor mqtt handler tests to include eventStore in newHandler function Signed-off-by: JeffMboya <[email protected]> NOISSUE - Add property based testing to things service (absmach#2088) Signed-off-by: Rodney Osodo <[email protected]> Signed-off-by: rodneyosodo <[email protected]> Signed-off-by: JeffMboya <[email protected]> Fix URLs in api-tests.yml Signed-off-by: JeffMboya <[email protected]> Add MQTT EventStore mock directive to check-generated-files.yml Signed-off-by: JeffMboya <[email protected]> Refactor mqtt handler tests to use svcCall instead of repoCall in handler_test.go Signed-off-by: JeffMboya <[email protected]> Replace mock.Anything in TestAuthConnect Signed-off-by: JeffMboya <[email protected]> Replace mock.Anything in TestDisconnect Signed-off-by: JeffMboya <[email protected]> Replace nil with tc.err in return values Signed-off-by: JeffMboya <[email protected]> Replace nil with tc.err in return values Signed-off-by: JeffMboya <[email protected]> NOISSUE - Update the location of MQTT API docs (absmach#2172) Signed-off-by: Emmanuel Ferdman <[email protected]> Replace context.Anything with respective context Signed-off-by: JeffMboya <[email protected]> Generate mocks with mockery for mqtt Signed-off-by: JeffMboya <[email protected]> Generate mocks with mockery for mqtt Signed-off-by: JeffMboya <[email protected]> Generate mocks with mockery for mqtt Signed-off-by: JeffMboya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature PR as it adds property-based testing to things API. In addition it is a refactor to error handling on the API
What does this do?
Adds schemathesis, property-based test, to things service
Which issue(s) does this PR fix/relate to?
No issue
Have you included tests for your changes?
Yes, I have included tests for my changes.
Did you document any new/modified feature?
No
Notes
To be merged after https://github.com/absmach/magistrala/pull/2087