Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Use NATS as MQTT broker #2681

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

rodneyosodo
Copy link
Member

@rodneyosodo rodneyosodo commented Feb 3, 2025

What type of PR is this?

This is a refactor because it removes removes VerneMQ as the MQTT broker and use NATS instead.

What does this do?

Enhancements:

  • Simplify the MQTT adapter configuration by removing unnecessary settings.

Tests:

  • Update tests to reflect the removal of VerneMQ.

Which issue(s) does this PR fix/relate to?

Related to #2021

Have you included tests for your changes?

Yes, I have included tests for my changes.

Did you document any new/modified feature?

Yes, I have updated the documentation for the new feature.

Notes

Sequence Diagram(s)

sequenceDiagram
    participant C as Client
    participant A as MQTT Adapter
    participant N as NATS Broker

    C->>A: Publish MQTT Message
    A->>N: Forward message (no MQTT tracing/forwarder)
    N-->>A: Acknowledge receipt
    A-->>C: Confirm delivery
Loading

@rodneyosodo rodneyosodo requested a review from a team as a code owner February 3, 2025 15:25
@dborovcanin dborovcanin changed the title NOISSUE - Remove VerneMQ NOISSUE - Use NATS as MQTT broker Feb 3, 2025
@dborovcanin dborovcanin merged commit cff6e7f into absmach:main Feb 3, 2025
5 of 7 checks passed
rodneyosodo added a commit to rodneyosodo/supermq that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants