Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Fix Websocket Adapter #2700

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rodneyosodo
Copy link
Member

@rodneyosodo rodneyosodo commented Feb 11, 2025

What type of PR is this?

This is a bug fix PR

What does this do?

It fixes web socket communication with other protocol adapters

Which issue(s) does this PR fix/relate to?

No issue

Have you included tests for your changes?

Tested manually

Did you document any new/modified feature?

Notes

To be merged after #2695

@rodneyosodo rodneyosodo requested a review from a team as a code owner February 11, 2025 12:05
@rodneyosodo rodneyosodo changed the title WS NOISSUE - Fix Websocket Adapter Feb 11, 2025
@rodneyosodo rodneyosodo marked this pull request as draft February 11, 2025 12:08
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.

Project coverage is 41.32%. Comparing base (17b5224) to head (fd776cc).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
ws/handler.go 0.00% 31 Missing ⚠️
ws/adapter.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2700      +/-   ##
==========================================
- Coverage   42.22%   41.32%   -0.91%     
==========================================
  Files         348       14     -334     
  Lines       47813      726   -47087     
==========================================
- Hits        20188      300   -19888     
+ Misses      25422      419   -25003     
+ Partials     2203        7    -2196     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rodneyosodo rodneyosodo force-pushed the fix-websocket branch 2 times, most recently from 55c53cb to ddc40fd Compare February 14, 2025 09:01
@rodneyosodo rodneyosodo force-pushed the fix-websocket branch 6 times, most recently from 192b2e0 to 293038d Compare February 26, 2025 09:04
@rodneyosodo rodneyosodo marked this pull request as ready for review February 26, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant